From: Greg KH <gregkh@linuxfoundation.org>
To: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Christoph Hellwig <hch@infradead.org>,
Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
Michael Ellerman <mpe@ellerman.id.au>,
linuxppc-dev@lists.ozlabs.org,
linux-s390 <linux-s390@vger.kernel.org>
Subject: Re: Linux 5.1-rc5
Date: Thu, 2 May 2019 16:31:10 +0200 [thread overview]
Message-ID: <20190502143110.GC17577@kroah.com> (raw)
In-Reply-To: <20190502161758.26972bb2@mschwideX1>
On Thu, May 02, 2019 at 04:17:58PM +0200, Martin Schwidefsky wrote:
> On Thu, 2 May 2019 14:21:28 +0200
> Greg KH <gregkh@linuxfoundation.org> wrote:
>
> > On Mon, Apr 15, 2019 at 09:17:10AM -0700, Linus Torvalds wrote:
> > > On Sun, Apr 14, 2019 at 10:19 PM Christoph Hellwig <hch@infradead.org> wrote:
> > > >
> > > > Can we please have the page refcount overflow fixes out on the list
> > > > for review, even if it is after the fact?
> > >
> > > They were actually on a list for review long before the fact, but it
> > > was the security mailing list. The issue actually got discussed back
> > > in January along with early versions of the patches, but then we
> > > dropped the ball because it just wasn't on anybody's radar and it got
> > > resurrected late March. Willy wrote a rather bigger patch-series, and
> > > review of that is what then resulted in those commits. So they may
> > > look recent, but that's just because the original patches got
> > > seriously edited down and rewritten.
> > >
> > > That said, powerpc and s390 should at least look at maybe adding a
> > > check for the page ref in their gup paths too. Powerpc has the special
> > > gup_hugepte() case, and s390 has its own version of gup entirely. I
> > > was actually hoping the s390 guys would look at using the generic gup
> > > code.
> > >
> > > I ruthlessly also entirely ignored MIPS, SH and sparc, since they seem
> > > largely irrelevant, partly since even theoretically this whole issue
> > > needs a _lot_ of memory.
> > >
> > > Michael, Martin, see commit 6b3a70773630 ("Merge branch 'page-refs'
> > > (page ref overflow)"). You may or may not really care.
> >
> > I've now queued these patches up for the next round of stable releases,
> > as some people seem to care about these.
> >
> > I didn't see any follow-on patches for s390 or ppc64 hit the tree for
> > these changes, am I just missing them and should also queue up a few
> > more to handle this issue on those platforms?
>
> I fixed that with a different approach. The following two patches are
> queued for the next merge window:
>
> d1874a0c2805 "s390/mm: make the pxd_offset functions more robust"
> 1a42010cdc26 "s390/mm: convert to the generic get_user_pages_fast code"
>
> With these two s390 now uses the generic gup code in mm/gup.c
Nice! Do you want me to queue those up for the stable backports once
they hit a public -rc release?
thanks,
greg k-h
next prev parent reply other threads:[~2019-05-02 14:31 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-14 22:40 Linux 5.1-rc5 Linus Torvalds
2019-04-15 5:19 ` Christoph Hellwig
2019-04-15 16:17 ` Linus Torvalds
2019-04-16 9:09 ` Martin Schwidefsky
2019-04-16 12:06 ` Martin Schwidefsky
2019-04-16 16:16 ` Linus Torvalds
2019-04-16 16:49 ` Linus Torvalds
2019-04-17 7:46 ` Martin Schwidefsky
2019-04-17 8:02 ` Martin Schwidefsky
2019-04-17 16:57 ` Linus Torvalds
2019-04-18 8:02 ` Martin Schwidefsky
2019-04-18 15:49 ` Linus Torvalds
2019-04-18 18:41 ` Martin Schwidefsky
2019-04-19 13:33 ` Martin Schwidefsky
2019-04-19 17:27 ` Linus Torvalds
2019-04-23 15:38 ` Martin Schwidefsky
2019-04-23 16:06 ` Linus Torvalds
2019-04-17 3:38 ` Michael Ellerman
2019-04-17 4:13 ` Linus Torvalds
2019-05-02 12:21 ` Greg KH
2019-05-02 14:17 ` Martin Schwidefsky
2019-05-02 14:31 ` Greg KH [this message]
2019-05-02 15:10 ` Martin Schwidefsky
2019-05-20 11:09 ` Greg KH
2019-05-03 13:31 ` Michael Ellerman
2019-05-02 23:15 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190502143110.GC17577@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=schwidefsky@de.ibm.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).