From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,T_DKIMWL_WL_HIGH,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2804C43219 for ; Thu, 2 May 2019 15:38:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 694B920449 for ; Thu, 2 May 2019 15:38:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556811502; bh=1gjrfluYwUBE3K70vJdJMHCLU+X59fbbSrS+7zPtUPA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=MRnt9ePTW6KlCLzihv12qlvEHMfQRAyEYO206Mi3AkHHgFbWXZWT3KasHXx/vjYwN OhyU+T2Ntfysf+REeajorMHFGqJ/PughWGYU0KpjYKcp/Kvu7h8Za6AEagQxIf9FPx 9LpSiDk/BMAWwMGXAUJWvpn8eihj0LVzHI0xJSIg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728625AbfEBPaE (ORCPT ); Thu, 2 May 2019 11:30:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:48250 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728567AbfEBPaC (ORCPT ); Thu, 2 May 2019 11:30:02 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C627F20B7C; Thu, 2 May 2019 15:30:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556811002; bh=1gjrfluYwUBE3K70vJdJMHCLU+X59fbbSrS+7zPtUPA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=N1ezWN74Lz61b1lS02nmmShiTyuzQncugXLYJeCHPravwSgu+id2jmEANxm9zdE81 +fo8WCmIEtdDTLlILdOuVvsbAQ5El8W1CkcyumKX6DKzCIT2UPx0jYPysFMaK+jMDQ 1g6YTIlvX4Ej2g1KYRT7MTCfqxYLr4n0ZVgOW0oQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Alan Stern , Guido Kiener , Felipe Balbi , "Sasha Levin (Microsoft)" Subject: [PATCH 5.0 038/101] usb: gadget: net2272: Fix net2272_dequeue() Date: Thu, 2 May 2019 17:20:40 +0200 Message-Id: <20190502143342.250545430@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190502143339.434882399@linuxfoundation.org> References: <20190502143339.434882399@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 091dacc3cc10979ab0422f0a9f7fcc27eee97e69 ] Restore the status of ep->stopped in function net2272_dequeue(). When the given request is not found in the endpoint queue the function returns -EINVAL without restoring the state of ep->stopped. Thus the endpoint keeps blocked and does not transfer any data anymore. This fix is only compile-tested, since we do not have a corresponding hardware. An analogous fix was tested in the sibling driver. See "usb: gadget: net2280: Fix net2280_dequeue()" Acked-by: Alan Stern Signed-off-by: Guido Kiener Signed-off-by: Felipe Balbi Signed-off-by: Sasha Levin (Microsoft) --- drivers/usb/gadget/udc/net2272.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/udc/net2272.c b/drivers/usb/gadget/udc/net2272.c index b77f3126580e..c2011cd7df8c 100644 --- a/drivers/usb/gadget/udc/net2272.c +++ b/drivers/usb/gadget/udc/net2272.c @@ -945,6 +945,7 @@ net2272_dequeue(struct usb_ep *_ep, struct usb_request *_req) break; } if (&req->req != _req) { + ep->stopped = stopped; spin_unlock_irqrestore(&ep->dev->lock, flags); return -EINVAL; } -- 2.19.1