From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,T_DKIMWL_WL_HIGH,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23301C43219 for ; Thu, 2 May 2019 15:30:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DEB4420B7C for ; Thu, 2 May 2019 15:30:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556811033; bh=CQdNOpkCUYS+fJWizHJvurWoB2prYbApk3+vaXeZ2gk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=N72/6+o+qQhUeYvnqjB/bCTSk4SD6jz9mApLL6LvlrZhpZ5vRGmbZzWwB2Wa0UjsN DqcpXS02+3cuWOkW8EdV72NmmStNzaA9KmMHHsGgEfV1mwVXaidCyTJAcwqbrmlAOz TF+Qs9tTT9GhJmC/Xz+SB/q57OR9VglYIRKaM8WM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728754AbfEBPab (ORCPT ); Thu, 2 May 2019 11:30:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:48984 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727888AbfEBPa1 (ORCPT ); Thu, 2 May 2019 11:30:27 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5DE1B20C01; Thu, 2 May 2019 15:30:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556811026; bh=CQdNOpkCUYS+fJWizHJvurWoB2prYbApk3+vaXeZ2gk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jwLWDUuYQJ3BYaJo/WfxGUnvt4m52i2ELLoJ62KVw+Y41+LJrHboWQS+n299cjYC3 4rJ0qkvSO03pkzEZdh4hf4ux71lgfUHbRglUrOh4P1EVhZIozrMczewiS+CWwiSl6m ltxUj/uGO8A0z5naSmXGsG8476O2r34JAmYQL74A= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Aditya Pakki , Mukesh Ojha , "Sasha Levin (Microsoft)" Subject: [PATCH 5.0 047/101] staging: rtlwifi: rtl8822b: fix to avoid potential NULL pointer dereference Date: Thu, 2 May 2019 17:20:49 +0200 Message-Id: <20190502143342.854481854@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190502143339.434882399@linuxfoundation.org> References: <20190502143339.434882399@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit d70d70aec9632679dd00dcc1b1e8b2517e2c7da0 ] skb allocated via dev_alloc_skb can fail and return a NULL pointer. This patch avoids such a scenario and returns, consistent with other invocations. Signed-off-by: Aditya Pakki Reviewed-by: Mukesh Ojha Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin (Microsoft) --- drivers/staging/rtlwifi/rtl8822be/fw.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/rtlwifi/rtl8822be/fw.c b/drivers/staging/rtlwifi/rtl8822be/fw.c index a40396614814..c1ed52df05f0 100644 --- a/drivers/staging/rtlwifi/rtl8822be/fw.c +++ b/drivers/staging/rtlwifi/rtl8822be/fw.c @@ -741,6 +741,8 @@ void rtl8822be_set_fw_rsvdpagepkt(struct ieee80211_hw *hw, bool b_dl_finished) u1_rsvd_page_loc, 3); skb = dev_alloc_skb(totalpacketlen); + if (!skb) + return; memcpy((u8 *)skb_put(skb, totalpacketlen), &reserved_page_packet, totalpacketlen); -- 2.19.1