From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,T_DKIMWL_WL_HIGH,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABA46C43219 for ; Thu, 2 May 2019 15:33:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6CA84216FD for ; Thu, 2 May 2019 15:33:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556811187; bh=mVORm+0ku597W0sEvQH4ehVlIGITPVEsH7yBofTk18Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=08RvwunqYQo0wCxmlbKXMGeJ9PxgfCYlimU05bs88PDeqASd7QbWbK5dlDiKEDJAq KV928c9u2nsvOPf0hFhopLvEa3V2YljAdEcnZo0TQgrCOnotsh/bQoUN5Ra3Lovvjg FDvZ7K969uh7YgNkhKNffIkJxK0uPghukFzoXACE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728941AbfEBPdF (ORCPT ); Thu, 2 May 2019 11:33:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:53068 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726371AbfEBPdB (ORCPT ); Thu, 2 May 2019 11:33:01 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 402F02081C; Thu, 2 May 2019 15:33:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556811180; bh=mVORm+0ku597W0sEvQH4ehVlIGITPVEsH7yBofTk18Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vr2NM7Lu9W/EPxWoo4aLbOPZKlW7iD79RDrVwatlWRC7v96M4mE3odTPnqQXoP5cs eRfiTFyxzFVexJXSue6IxWPeQkuEOgMHpxkfxIZgyYrSfcLXTWJhlmw0wGh6ldoReK 1BA5HNrZzc/A9BnMAUfMAk73NiCbUd5A94Q+cqsY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Mukesh Ojha , "Sasha Levin (Microsoft)" Subject: [PATCH 5.0 073/101] usb: u132-hcd: fix resource leak Date: Thu, 2 May 2019 17:21:15 +0200 Message-Id: <20190502143344.794860557@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190502143339.434882399@linuxfoundation.org> References: <20190502143339.434882399@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit f276e002793cdb820862e8ea8f76769d56bba575 ] if platform_driver_register fails, cleanup the allocated resource gracefully. Signed-off-by: Mukesh Ojha Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin (Microsoft) --- drivers/usb/host/u132-hcd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/host/u132-hcd.c b/drivers/usb/host/u132-hcd.c index 5b8a3d9530c4..5cac83aaeac3 100644 --- a/drivers/usb/host/u132-hcd.c +++ b/drivers/usb/host/u132-hcd.c @@ -3202,6 +3202,9 @@ static int __init u132_hcd_init(void) printk(KERN_INFO "driver %s\n", hcd_name); workqueue = create_singlethread_workqueue("u132"); retval = platform_driver_register(&u132_platform_driver); + if (retval) + destroy_workqueue(workqueue); + return retval; } -- 2.19.1