From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 956D2C04AAA for ; Thu, 2 May 2019 15:00:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 63DEB2075E for ; Thu, 2 May 2019 15:00:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="jlPMKdBl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726418AbfEBPAG (ORCPT ); Thu, 2 May 2019 11:00:06 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:36737 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726267AbfEBPAG (ORCPT ); Thu, 2 May 2019 11:00:06 -0400 Received: by mail-pg1-f194.google.com with SMTP id 85so1190568pgc.3 for ; Thu, 02 May 2019 08:00:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=+h3hw8s9AtbUTxjsRg8h8D8msF/wrKXAgqEpw8EeNOA=; b=jlPMKdBldP3f4gKDgtqtVH6KYU8BBSCgulAP9KFpHF3ggzd6GSvZz16mK18TthOsMB 1vIdQs+yeoBsgHJk6YekXKdpVP9K50gEgw25xuVBTGoxyyoHb29xzJ1Ag7owhc4iWbJH 3vtoFqsW+jMQOE51MrgTIxpPqNuJeob2IO2cLCizNlQi3tIitPvtK0sQj6ZbAjSSmi7Q How1Fdr5GunZ9wIhUNpe8lJnwvz4fLYdBh0eoo7nwRiWBdB4lO/rCUKPbZYMYOEWstK6 X9eprPBu7iBiQdu2/W6KBPXy8NJJCdW7KNyEh5OU4DREjJDfxop3p+3u0QEieu4jXfUx qsOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=+h3hw8s9AtbUTxjsRg8h8D8msF/wrKXAgqEpw8EeNOA=; b=QFqrSp3G+i+SV6DXBBKyMKndOroAQRzTXp+6BB+5QBpJ+uPb6nWNwq1AiUgy+6b4g9 ALdACQL5azQZTFk+IpIYtmh9gqt7TtFNSCaTGvzv0M1DalhZkWOLYSgBZxfHhBTYeBpH vumNcxVRjhtTRHx0c3H6AyZNTgbiEthav12E4uKRBDSbfMB68CTtimXIzx8KxnfMxEE5 /iJEXf92Ql/3fc8ThMquIGgntX1W1CLau85E3rU6DxOKfxk0HJKthm2jMObrvqHV5odr OEpt0+wjCW8P1s7Je41xXGvoVr6MjBr4XxlYtHwSiaHH1uy2zkW3ZCgydBEkgmTBVSiY smZA== X-Gm-Message-State: APjAAAXdjPllxLL76PDntFtKnYbVcOvTl1mo3/PtGnPmQvcQciEYiH6W YgpGM8oMoP/20sE+753kKioGTw== X-Google-Smtp-Source: APXvYqxWyfb9Mb0R98oD1S3XalY5sExRiMmQ78TIyJ0AR6QKTKJB4fZ9Az+LDCDt3uqkWQ2xI1kwEg== X-Received: by 2002:aa7:9242:: with SMTP id 2mr1888978pfp.230.1556809205168; Thu, 02 May 2019 08:00:05 -0700 (PDT) Received: from tuxbook-pro (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id i3sm60549129pfa.90.2019.05.02.08.00.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 02 May 2019 08:00:03 -0700 (PDT) Date: Thu, 2 May 2019 08:00:06 -0700 From: Bjorn Andersson To: Vinod Koul Cc: Bjorn Helgaas , Stanimir Varbanov , Lorenzo Pieralisi , Rob Herring , Mark Rutland , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/3] PCI: qcom: Use clk_bulk API for 2.4.0 controllers Message-ID: <20190502150006.GL2938@tuxbook-pro> References: <20190502001955.10575-1-bjorn.andersson@linaro.org> <20190502001955.10575-2-bjorn.andersson@linaro.org> <20190502115351.GM3845@vkoul-mobl.Dlink> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190502115351.GM3845@vkoul-mobl.Dlink> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 02 May 04:53 PDT 2019, Vinod Koul wrote: > On 01-05-19, 17:19, Bjorn Andersson wrote: [..] > > diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c > > index 0ed235d560e3..d740cbe0e56d 100644 > > --- a/drivers/pci/controller/dwc/pcie-qcom.c > > +++ b/drivers/pci/controller/dwc/pcie-qcom.c > > @@ -112,10 +112,10 @@ struct qcom_pcie_resources_2_3_2 { > > struct regulator_bulk_data supplies[QCOM_PCIE_2_3_2_MAX_SUPPLY]; > > }; > > > > +#define QCOM_PCIE_2_4_0_MAX_CLOCKS 3 > > empty line after the define please > This follows the style of QCOM_PCIE_2_3_2_MAX_SUPPLY one block up, so I think this is the way we want it. > > struct qcom_pcie_resources_2_4_0 { [..] > > > rest lgtm: > > Reviewed-by: Vinod Koul > Thanks! Regards, Bjorn