From: Oscar Salvador <osalvador@suse.de>
To: Dan Williams <dan.j.williams@intel.com>
Cc: "Pavel Tatashin" <pasha.tatashin@soleen.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"David Hildenbrand" <david@redhat.com>,
"Jérôme Glisse" <jglisse@redhat.com>,
"Logan Gunthorpe" <logang@deltatee.com>,
"Toshi Kani" <toshi.kani@hpe.com>,
"Jeff Moyer" <jmoyer@redhat.com>,
"Michal Hocko" <mhocko@suse.com>,
"Vlastimil Babka" <vbabka@suse.cz>,
stable <stable@vger.kernel.org>, linux-mm <linux-mm@kvack.org>,
linux-nvdimm <linux-nvdimm@lists.01.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 00/12] mm: Sub-section memory hotplug support
Date: Fri, 3 May 2019 12:48:32 +0200 [thread overview]
Message-ID: <20190503104831.GF15740@linux> (raw)
In-Reply-To: <CAPcyv4gWZxSepaACiyR43qytA1jR8fVaeLy1rv7dFJW-ZE63EA@mail.gmail.com>
On Thu, May 02, 2019 at 04:20:03PM -0700, Dan Williams wrote:
> On Thu, May 2, 2019 at 3:46 PM Pavel Tatashin <pasha.tatashin@soleen.com> wrote:
> >
> > Hi Dan,
> >
> > How do you test these patches? Do you have any instructions?
>
> Yes, I briefly mentioned this in the cover letter, but here is the
> test I am using:
>
> >
> > I see for example that check_hotplug_memory_range() still enforces
> > memory_block_size_bytes() alignment.
> >
> > Also, after removing check_hotplug_memory_range(), I tried to online
> > 16M aligned DAX memory, and got the following panic:
>
> Right, this functionality is currently strictly limited to the
> devm_memremap_pages() case where there are guarantees that the memory
> will never be onlined. This is due to the fact that the section size
> is entangled with the memblock api. That said I would have expected
> you to trigger the warning in subsection_check() before getting this
> far into the hotplug process.
> >
> > # echo online > /sys/devices/system/memory/memory7/state
> > [ 202.193132] WARNING: CPU: 2 PID: 351 at drivers/base/memory.c:207
> > memory_block_action+0x110/0x178
> > [ 202.193391] Modules linked in:
> > [ 202.193698] CPU: 2 PID: 351 Comm: sh Not tainted
> > 5.1.0-rc7_pt_devdax-00038-g865af4385544-dirty #9
> > [ 202.193909] Hardware name: linux,dummy-virt (DT)
> > [ 202.194122] pstate: 60000005 (nZCv daif -PAN -UAO)
> > [ 202.194243] pc : memory_block_action+0x110/0x178
> > [ 202.194404] lr : memory_block_action+0x90/0x178
> > [ 202.194506] sp : ffff000016763ca0
> > [ 202.194592] x29: ffff000016763ca0 x28: ffff80016fd29b80
> > [ 202.194724] x27: 0000000000000000 x26: 0000000000000000
> > [ 202.194838] x25: ffff000015546000 x24: 00000000001c0000
> > [ 202.194949] x23: 0000000000000000 x22: 0000000000040000
> > [ 202.195058] x21: 00000000001c0000 x20: 0000000000000008
> > [ 202.195168] x19: 0000000000000007 x18: 0000000000000000
> > [ 202.195281] x17: 0000000000000000 x16: 0000000000000000
> > [ 202.195393] x15: 0000000000000000 x14: 0000000000000000
> > [ 202.195505] x13: 0000000000000000 x12: 0000000000000000
> > [ 202.195614] x11: 0000000000000000 x10: 0000000000000000
> > [ 202.195744] x9 : 0000000000000000 x8 : 0000000180000000
> > [ 202.195858] x7 : 0000000000000018 x6 : ffff000015541930
> > [ 202.195966] x5 : ffff000015541930 x4 : 0000000000000001
> > [ 202.196074] x3 : 0000000000000001 x2 : 0000000000000000
> > [ 202.196185] x1 : 0000000000000070 x0 : 0000000000000000
> > [ 202.196366] Call trace:
> > [ 202.196455] memory_block_action+0x110/0x178
> > [ 202.196589] memory_subsys_online+0x3c/0x80
> > [ 202.196681] device_online+0x6c/0x90
> > [ 202.196761] state_store+0x84/0x100
> > [ 202.196841] dev_attr_store+0x18/0x28
> > [ 202.196927] sysfs_kf_write+0x40/0x58
> > [ 202.197010] kernfs_fop_write+0xcc/0x1d8
> > [ 202.197099] __vfs_write+0x18/0x40
> > [ 202.197187] vfs_write+0xa4/0x1b0
> > [ 202.197295] ksys_write+0x64/0xd8
> > [ 202.197430] __arm64_sys_write+0x18/0x20
> > [ 202.197521] el0_svc_common.constprop.0+0x7c/0xe8
> > [ 202.197621] el0_svc_handler+0x28/0x78
> > [ 202.197706] el0_svc+0x8/0xc
> > [ 202.197828] ---[ end trace 57719823dda6d21e ]---
This warning relates to:
for (; section_nr < section_nr_end; section_nr++) {
if (WARN_ON_ONCE(!pfn_valid(pfn)))
return false;
from pages_correctly_probed().
AFAICS, this is orthogonal to subsection_check().
--
Oscar Salvador
SUSE L3
prev parent reply other threads:[~2019-05-03 10:48 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-17 18:38 [PATCH v6 00/12] mm: Sub-section memory hotplug support Dan Williams
2019-04-17 18:39 ` [PATCH v6 01/12] mm/sparsemem: Introduce struct mem_section_usage Dan Williams
2019-05-01 23:25 ` Pavel Tatashin
2019-05-02 6:07 ` Dan Williams
2019-05-02 14:16 ` Pavel Tatashin
2019-05-04 0:22 ` Dan Williams
2019-05-04 15:55 ` Pavel Tatashin
2019-04-17 18:39 ` [PATCH v6 02/12] mm/sparsemem: Introduce common definitions for the size and mask of a section Dan Williams
2019-05-02 14:53 ` Pavel Tatashin
2019-05-03 0:41 ` Dan Williams
2019-05-03 10:35 ` Robin Murphy
2019-05-03 12:57 ` Pavel Tatashin
2019-05-03 13:00 ` Oscar Salvador
2019-04-17 18:39 ` [PATCH v6 03/12] mm/sparsemem: Add helpers track active portions of a section at boot Dan Williams
2019-04-25 14:33 ` Oscar Salvador
2019-04-25 14:43 ` Oscar Salvador
2019-04-26 12:57 ` Oscar Salvador
2019-05-02 16:12 ` Pavel Tatashin
2019-05-04 19:26 ` Dan Williams
2019-04-17 18:39 ` [PATCH v6 04/12] mm/hotplug: Prepare shrink_{zone, pgdat}_span for sub-section removal Dan Williams
2019-04-19 23:09 ` Ralph Campbell
2019-04-19 23:13 ` Dan Williams
2019-04-26 13:59 ` Oscar Salvador
2019-04-26 14:00 ` Oscar Salvador
2019-05-02 19:18 ` Pavel Tatashin
2019-04-17 18:39 ` [PATCH v6 05/12] mm/sparsemem: Convert kmalloc_section_memmap() to populate_section_memmap() Dan Williams
2019-05-02 19:28 ` Pavel Tatashin
2019-04-17 18:39 ` [PATCH v6 06/12] mm/hotplug: Add mem-hotplug restrictions for remove_memory() Dan Williams
2019-04-23 21:21 ` David Hildenbrand
2019-04-24 18:07 ` Dan Williams
2019-04-17 18:39 ` [PATCH v6 07/12] mm: Kill is_dev_zone() helper Dan Williams
2019-04-17 20:17 ` David Hildenbrand
2019-04-26 14:04 ` Oscar Salvador
2019-05-02 20:37 ` Pavel Tatashin
2019-04-17 18:39 ` [PATCH v6 08/12] mm/sparsemem: Prepare for sub-section ranges Dan Williams
2019-05-02 21:25 ` Pavel Tatashin
2019-04-17 18:39 ` [PATCH v6 09/12] mm/sparsemem: Support sub-section hotplug Dan Williams
2019-04-17 18:39 ` [PATCH v6 10/12] mm/devm_memremap_pages: Enable sub-section remap Dan Williams
2019-04-17 18:39 ` [PATCH v6 11/12] libnvdimm/pfn: Fix fsdax-mode namespace info-block zero-fields Dan Williams
2019-04-17 22:02 ` Andrew Morton
2019-04-17 22:09 ` Dan Williams
2019-04-17 18:39 ` [PATCH v6 12/12] libnvdimm/pfn: Stop padding pmem namespaces to section alignment Dan Williams
2019-04-17 22:03 ` [PATCH v6 00/12] mm: Sub-section memory hotplug support Andrew Morton
2019-04-17 22:59 ` Dan Williams
2019-04-18 2:09 ` Dan Williams
2019-04-18 12:45 ` Jeff Moyer
2019-04-19 3:25 ` Dan Williams
2019-04-23 13:16 ` Oscar Salvador
2019-04-24 20:43 ` Pavel Tatashin
2019-05-02 22:46 ` Pavel Tatashin
2019-05-02 23:20 ` Dan Williams
2019-05-02 23:21 ` Dan Williams
2019-05-03 10:48 ` Oscar Salvador [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190503104831.GF15740@linux \
--to=osalvador@suse.de \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=jglisse@redhat.com \
--cc=jmoyer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=logang@deltatee.com \
--cc=mhocko@suse.com \
--cc=pasha.tatashin@soleen.com \
--cc=stable@vger.kernel.org \
--cc=toshi.kani@hpe.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).