From: Joe Lawrence <joe.lawrence@redhat.com>
To: Petr Mladek <pmladek@suse.com>
Cc: Jiri Kosina <jikos@kernel.org>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Miroslav Benes <mbenes@suse.cz>,
Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>,
"Tobin C . Harding" <tobin@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
live-patching@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] livepatch: Remove custom kobject state handling and duplicated code
Date: Fri, 3 May 2019 11:39:09 -0400 [thread overview]
Message-ID: <20190503153909.GD24094@redhat.com> (raw)
In-Reply-To: <20190503132625.23442-1-pmladek@suse.com>
On Fri, May 03, 2019 at 03:26:23PM +0200, Petr Mladek wrote:
> Tobin's patch[1] uncovered that the livepatching code handles kobjects
> a too complicated way.
>
> The first patch removes the unnecessary custom kobject state handling.
>
> The second patch is an optional code deduplication. I did something
> similar already when introducing the atomic replace. But it was
> not considered worth it. There are more duplicated things now...
>
> [1] https://lkml.kernel.org/r/20190430001534.26246-1-tobin@kernel.org
>
>
> Petr Mladek (2):
> livepatch: Remove custom kobject state handling
> livepatch: Remove duplicated code for early initialization
>
> include/linux/livepatch.h | 3 --
> kernel/livepatch/core.c | 86 ++++++++++++++++++++---------------------------
> 2 files changed, 37 insertions(+), 52 deletions(-)
>
> --
> 2.16.4
>
For the series,
Acked-by: Joe Lawrence <joe.lawrence@redhat.com>
-- Joe
next prev parent reply other threads:[~2019-05-03 15:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-03 13:26 [PATCH 0/2] livepatch: Remove custom kobject state handling and duplicated code Petr Mladek
2019-05-03 13:26 ` [PATCH 1/2] livepatch: Remove custom kobject state handling Petr Mladek
2019-05-03 16:35 ` Kamalesh Babulal
2019-05-07 12:32 ` Miroslav Benes
2019-05-07 13:06 ` Greg Kroah-Hartman
2019-05-03 13:26 ` [PATCH 2/2] livepatch: Remove duplicated code for early initialization Petr Mladek
2019-05-03 16:35 ` Kamalesh Babulal
2019-05-03 15:39 ` Joe Lawrence [this message]
2019-05-03 19:16 ` [PATCH 0/2] livepatch: Remove custom kobject state handling and duplicated code Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190503153909.GD24094@redhat.com \
--to=joe.lawrence@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jikos@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=kamalesh@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=pmladek@suse.com \
--cc=tobin@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).