From: David Miller <davem@davemloft.net>
To: mkubecek@suse.cz
Cc: netdev@vger.kernel.org, johannes@sipsolutions.net,
dsahern@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 0/3] netlink: strict attribute checking follow-up
Date: Sat, 04 May 2019 01:27:56 -0400 (EDT) [thread overview]
Message-ID: <20190504.012756.510495833576060196.davem@davemloft.net> (raw)
In-Reply-To: <cover.1556806084.git.mkubecek@suse.cz>
From: Michal Kubecek <mkubecek@suse.cz>
Date: Thu, 2 May 2019 16:15:10 +0200 (CEST)
> Three follow-up patches for recent strict netlink validation series.
>
> Patch 1 fixes dump handling for genetlink families which validate and parse
> messages themselves (e.g. because they need different policies for diferent
> commands).
>
> Patch 2 sets bad_attr in extack in one place where this was omitted.
>
> Patch 3 adds new NL_VALIDATE_NESTED flags for strict validation to enable
> checking that NLA_F_NESTED value in received messages matches expectations
> and includes this flag in NL_VALIDATE_STRICT. This would change userspace
> visible behavior but the previous switching to NL_VALIDATE_STRICT for new
> code is still only in net-next at the moment.
>
> v2: change error messages to mention NLA_F_NESTED explicitly
Series applied.
prev parent reply other threads:[~2019-05-04 5:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-02 14:15 [PATCH net-next v2 0/3] netlink: strict attribute checking follow-up Michal Kubecek
2019-05-02 14:15 ` [PATCH net-next v2 1/3] genetlink: do not validate dump requests if there is no policy Michal Kubecek
2019-05-02 14:15 ` [PATCH net-next v2 3/3] netlink: add validation of NLA_F_NESTED flag Michal Kubecek
2019-05-02 15:30 ` Johannes Berg
2019-05-02 22:56 ` David Ahern
2019-07-23 8:57 ` Thomas Haller
2019-07-23 9:09 ` Michal Kubecek
2019-07-23 9:28 ` Thomas Haller
2019-07-25 2:46 ` David Ahern
2019-07-23 18:02 ` Stephen Hemminger
2019-07-23 18:17 ` Johannes Berg
2019-05-02 14:15 ` [PATCH net-next v2 2/3] netlink: set bad attribute also on maxtype check Michal Kubecek
2019-05-04 5:27 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190504.012756.510495833576060196.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).