From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D555AC43219 for ; Sat, 4 May 2019 06:54:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A4D52206BB for ; Sat, 4 May 2019 06:54:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="jPezRXAE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726963AbfEDGyK (ORCPT ); Sat, 4 May 2019 02:54:10 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:43227 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726622AbfEDGyJ (ORCPT ); Sat, 4 May 2019 02:54:09 -0400 Received: by mail-pg1-f195.google.com with SMTP id t22so3802603pgi.10 for ; Fri, 03 May 2019 23:54:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=gqyA9w6RcMTkaC1wlrGYiIZtj1uy6ZoYFIu5t9JyriA=; b=jPezRXAEY669SQbZu/6bAvGUuYDGTH/MEjwYqbzwbVaAG/LALvOho6XqI9/tKuCg5k 97jvuYYHpxQPkb70kyY6+qdqEtzAjEuQYcTOC42IK2C9x4WepVk4XosPjIO7ltRo8XOM b6RZ5LuXsuLItHlqWK29Nk8bzZB+86OgAj+kE04Sk+XqwobHNUYQwdlOTPIRDNuSpEYc W9aIzubh2IsmMqbAC+toy0jGJ6XUgDUJnajqX4s6lGljxFDmvGm/PltFnkQJNeHj/d+v hTlrMbcn1l49qeJrjY0P2/urLIJ99auo+MI8B0BWmgqUu7Eb3EbvfXpf18tYYMwWDXqT kU5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=gqyA9w6RcMTkaC1wlrGYiIZtj1uy6ZoYFIu5t9JyriA=; b=uNTkFxOht8q7GRfDqhiL8acLNNhlJ8D5dJIvU6OkPYq/tpHQViv8SOMb0jr6A7/wiC zVZIWkxERLnySqMp/9ShpPL304Q3HSfK6n8+ZByogRiUtCOnn6W+WV/0ug1NJIQ5UGrP pvkjp7+6YgQG1VSqU4/D52dF7nF+GWJiYqJcNg+OcNq/66coumdytY4Yzw0UrXTOPTZ3 gn2sJiTBU0YgpMtpfojQn3qG1Wqnfxm09jINIzBiS7vd4eSpAbF9yENK9CUCV5MIN5aG 58M4CNK1AJ41k3pAudxp/89awa+knRgQpzJ0/++sOFwow91s6SSxHmuA8rtCNcNdbwGx sUcg== X-Gm-Message-State: APjAAAWdbps6iZDpZE+LFaPdgsmX7ahzDAgX5HVJAxL+EySj3fXuKMUA g9I0S3MZayF1oeNhqNnm1KbTmA== X-Google-Smtp-Source: APXvYqwE1Fot3eHa0e9hWyuSTftja1FGOlZ271uN0ygTu5BNBapRvhKLGijzB4soIdw2kWbKZ+M+0A== X-Received: by 2002:a62:3501:: with SMTP id c1mr17569232pfa.184.1556952849325; Fri, 03 May 2019 23:54:09 -0700 (PDT) Received: from cakuba.netronome.com (ip-184-212-224-194.bympra.spcsdns.net. [184.212.224.194]) by smtp.gmail.com with ESMTPSA id s20sm5434573pgs.39.2019.05.03.23.54.05 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 03 May 2019 23:54:09 -0700 (PDT) Date: Sat, 4 May 2019 02:53:53 -0400 From: Jakub Kicinski To: Maxime Chevallier Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Antoine Tenart , thomas.petazzoni@bootlin.com, gregory.clement@bootlin.com, miquel.raynal@bootlin.com, nadavh@marvell.com, stefanc@marvell.com, mw@semihalf.com, Russell King , linux-arm-kernel@lists.infradead.org, Saeed Mahameed Subject: Re: [PATCH net-next 0/4] net: mvpp2: cls: Add classification Message-ID: <20190504025353.74acbb6d@cakuba.netronome.com> In-Reply-To: <20190430131429.19361-1-maxime.chevallier@bootlin.com> References: <20190430131429.19361-1-maxime.chevallier@bootlin.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 30 Apr 2019 15:14:25 +0200, Maxime Chevallier wrote: > Compared to the first submissions, the NETIF_F_NTUPLE flag was also > removed, following Saeed's comment. You should probably add it back, even though the stack only uses NETIF_F_NTUPLE for aRFS the ethtool APIs historically depend on the drivers doing a lot of the validation. The flag was added by: 15682bc488d4 ("ethtool: Introduce n-tuple filter programming support") your initial use of the flag was correct.