From: Michal Hocko <mhocko@kernel.org>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
Oleg Nesterov <oleg@redhat.com>
Subject: Re: [PATCH] signal: reorder struct sighand_struct
Date: Sat, 4 May 2019 19:33:02 -0400 [thread overview]
Message-ID: <20190504233302.GT29835@dhcp22.suse.cz> (raw)
In-Reply-To: <20190503192800.GA18004@avx2>
CCing Oleg.
On Fri 03-05-19 22:28:00, Alexey Dobriyan wrote:
[...]
> add/remove: 0/0 grow/shrink: 8/68 up/down: 49/-1147 (-1098)
[...]
> --- a/include/linux/sched/signal.h
> +++ b/include/linux/sched/signal.h
> @@ -15,10 +15,10 @@
> */
>
> struct sighand_struct {
> - refcount_t count;
> - struct k_sigaction action[_NSIG];
> spinlock_t siglock;
> + refcount_t count;
> wait_queue_head_t signalfd_wqh;
> + struct k_sigaction action[_NSIG];
> };
Is it possible that this would cause false sharing of the cache line
that would have performance implications now?
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2019-05-04 23:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-03 19:28 [PATCH] signal: reorder struct sighand_struct Alexey Dobriyan
2019-05-04 23:33 ` Michal Hocko [this message]
2019-05-24 2:11 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190504233302.GT29835@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).