* [PATCH] net: ll_temac: Improve error message on error IRQ
@ 2019-05-07 6:42 Esben Haabendal
2019-05-07 19:25 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Esben Haabendal @ 2019-05-07 6:42 UTC (permalink / raw)
To: netdev
Cc: David S. Miller, Michal Simek, Andrew Lunn, YueHaibing, Yang Wei,
Luis Chamberlain, linux-arm-kernel, linux-kernel
The channel status register value can be very helpful when debugging
SDMA problems.
Signed-off-by: Esben Haabendal <esben@geanix.com>
---
drivers/net/ethernet/xilinx/ll_temac_main.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/ethernet/xilinx/ll_temac_main.c
index 9851991..36fc4c4 100644
--- a/drivers/net/ethernet/xilinx/ll_temac_main.c
+++ b/drivers/net/ethernet/xilinx/ll_temac_main.c
@@ -886,8 +886,10 @@ static irqreturn_t ll_temac_tx_irq(int irq, void *_ndev)
if (status & (IRQ_COAL | IRQ_DLY))
temac_start_xmit_done(lp->ndev);
- if (status & 0x080)
- dev_err(&ndev->dev, "DMA error 0x%x\n", status);
+ if (status & (IRQ_ERR | IRQ_DMAERR))
+ dev_err_ratelimited(&ndev->dev,
+ "TX error 0x%x TX_CHNL_STS=0x%08x\n",
+ status, lp->dma_in(lp, TX_CHNL_STS));
return IRQ_HANDLED;
}
@@ -904,6 +906,10 @@ static irqreturn_t ll_temac_rx_irq(int irq, void *_ndev)
if (status & (IRQ_COAL | IRQ_DLY))
ll_temac_recv(lp->ndev);
+ if (status & (IRQ_ERR | IRQ_DMAERR))
+ dev_err_ratelimited(&ndev->dev,
+ "RX error 0x%x RX_CHNL_STS=0x%08x\n",
+ status, lp->dma_in(lp, RX_CHNL_STS));
return IRQ_HANDLED;
}
--
2.4.11
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: ll_temac: Improve error message on error IRQ
2019-05-07 6:42 [PATCH] net: ll_temac: Improve error message on error IRQ Esben Haabendal
@ 2019-05-07 19:25 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-05-07 19:25 UTC (permalink / raw)
To: esben
Cc: netdev, michal.simek, andrew, yuehaibing, yang.wei9, mcgrof,
linux-arm-kernel, linux-kernel
From: Esben Haabendal <esben@geanix.com>
Date: Tue, 7 May 2019 08:42:57 +0200
> The channel status register value can be very helpful when debugging
> SDMA problems.
>
> Signed-off-by: Esben Haabendal <esben@geanix.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-05-07 19:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-07 6:42 [PATCH] net: ll_temac: Improve error message on error IRQ Esben Haabendal
2019-05-07 19:25 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).