From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: Niklas Cassel <niklas.cassel@linaro.org>,
Andy Gross <agross@kernel.org>,
David Brown <david.brown@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
amit.kucheria@linaro.org, jorge.ramirez-ortiz@linaro.org,
lina.iyer@linaro.org, ulf.hansson@linaro.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: qcs404: Add PSCI cpuidle support
Date: Mon, 6 May 2019 23:55:55 -0700 [thread overview]
Message-ID: <20190507065555.GB2085@tuxbook-pro> (raw)
In-Reply-To: <20190507053547.GE16052@vkoul-mobl>
On Mon 06 May 22:35 PDT 2019, Vinod Koul wrote:
> On 06-05-19, 21:31, Niklas Cassel wrote:
> > Add device bindings for CPUs to suspend using PSCI as the enable-method.
> >
> > Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
> > ---
> > arch/arm64/boot/dts/qcom/qcs404.dtsi | 15 +++++++++++++++
> > 1 file changed, 15 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi b/arch/arm64/boot/dts/qcom/qcs404.dtsi
> > index ffedf9640af7..f9db9f3ee10c 100644
> > --- a/arch/arm64/boot/dts/qcom/qcs404.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/qcs404.dtsi
> > @@ -31,6 +31,7 @@
> > reg = <0x100>;
> > enable-method = "psci";
> > next-level-cache = <&L2_0>;
> > + cpu-idle-states = <&CPU_PC>;
> > };
> >
> > CPU1: cpu@101 {
> > @@ -39,6 +40,7 @@
> > reg = <0x101>;
> > enable-method = "psci";
> > next-level-cache = <&L2_0>;
> > + cpu-idle-states = <&CPU_PC>;
> > };
> >
> > CPU2: cpu@102 {
> > @@ -47,6 +49,7 @@
> > reg = <0x102>;
> > enable-method = "psci";
> > next-level-cache = <&L2_0>;
> > + cpu-idle-states = <&CPU_PC>;
> > };
> >
> > CPU3: cpu@103 {
> > @@ -55,12 +58,24 @@
> > reg = <0x103>;
> > enable-method = "psci";
> > next-level-cache = <&L2_0>;
> > + cpu-idle-states = <&CPU_PC>;
> > };
> >
> > L2_0: l2-cache {
> > compatible = "cache";
> > cache-level = <2>;
> > };
> > +
> > + idle-states {
>
> Since we are trying to sort the file per address and
> alphabetically, it would be great if this can be moved before l2-cache
> :)
>
Picked up, with the order adjusted.
> Other than that this lgtm
>
I presume that lgtm == Reviewed-by...
Thanks,
Bjorn
> > + CPU_PC: pc {
> > + compatible = "arm,idle-state";
> > + arm,psci-suspend-param = <0x40000003>;
> > + entry-latency-us = <125>;
> > + exit-latency-us = <180>;
> > + min-residency-us = <595>;
> > + local-timer-stop;
> > + };
> > + };
> > };
> >
> > firmware {
> > --
> > 2.21.0
>
> --
> ~Vinod
next prev parent reply other threads:[~2019-05-07 6:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-06 19:31 [PATCH] arm64: dts: qcom: qcs404: Add PSCI cpuidle support Niklas Cassel
2019-05-07 5:35 ` Vinod Koul
2019-05-07 6:55 ` Bjorn Andersson [this message]
2019-05-07 7:06 ` Vinod Koul
2019-05-10 11:31 ` Amit Kucheria
2019-05-07 21:18 ` Amit Kucheria
2019-05-08 14:56 ` Niklas Cassel
2019-05-09 17:49 ` Amit Kucheria
2019-05-10 9:24 ` Sudeep Holla
2019-05-10 18:28 ` Amit Kucheria
2019-05-13 9:49 ` Sudeep Holla
2019-05-15 9:56 ` Amit Kucheria
2019-05-15 10:30 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190507065555.GB2085@tuxbook-pro \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=amit.kucheria@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jorge.ramirez-ortiz@linaro.org \
--cc=lina.iyer@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=niklas.cassel@linaro.org \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).