From: Ingo Molnar <mingo@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Waiman Long <longman9394@gmail.com>,
Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Will Deacon <will.deacon@arm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [GIT PULL] locking changes for v5.2
Date: Tue, 7 May 2019 10:24:13 +0200 [thread overview]
Message-ID: <20190507082413.GA125993@gmail.com> (raw)
In-Reply-To: <CAHk-=wifHYK-NKCTbT3_iHpy3QeK7H+=RLbFUaFpPziPn3O8Ng@mail.gmail.com>
* Linus Torvalds <torvalds@linux-foundation.org> wrote:
> On Mon, May 6, 2019 at 12:43 PM Ingo Molnar <mingo@kernel.org> wrote:
> >
> > Sure - how close is this to a straight:
> >
> > git revert 70800c3c0cc5
>
> It's not really a revert. The code is different (and better) from the
> straight revert, but perhaps equally importantly it also ends up with
> a big comment about what's going on that made the original commit
> wrong.
>
> So I'd suggest just taking the patch as-is, and not calling it a
> revert. It may revert to the original _model_ of wakup list traversal,
> but it does so differently enough that the patch itself is not a
> revert.
Ok, Waiman's patch is now the following commit in locking/urgent:
a9e9bcb45b15: ("locking/rwsem: Prevent decrement of reader count before increment")
it should get to you in a couple of days.
Thanks,
Ingo
next prev parent reply other threads:[~2019-05-07 8:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-06 8:50 [GIT PULL] locking changes for v5.2 Ingo Molnar
2019-05-06 16:11 ` Waiman Long
2019-05-06 19:43 ` Ingo Molnar
2019-05-06 20:55 ` Linus Torvalds
2019-05-06 22:39 ` Ingo Molnar
2019-05-07 8:24 ` Ingo Molnar [this message]
2019-05-07 14:39 ` Waiman Long
2019-05-06 23:40 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190507082413.GA125993@gmail.com \
--to=mingo@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longman9394@gmail.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).