From: Daniel Thompson <daniel.thompson@linaro.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Douglas Anderson <dianders@chromium.org>,
Jason Wessel <jason.wessel@windriver.com>,
Christophe Leroy <christophe.leroy@c-s.fr>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Kees Cook <keescook@chromium.org>,
kgdb-bugreport@lists.sourceforge.net,
Johannes Weiner <hannes@cmpxchg.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Nicholas Mc Guire <hofrat@osadl.org>,
Andrew Morton <akpm@linux-foundation.org>,
Joe Perches <joe@perches.com>
Subject: Re: [PATCH] kdb: Get rid of broken attempt to print CCVERSION in kdb summary
Date: Tue, 7 May 2019 14:55:12 +0100 [thread overview]
Message-ID: <20190507135512.5fyy3zu7ljjaeg3u@holly.lan> (raw)
In-Reply-To: <CAK7LNATFrp=4JcqU2pFJ-+06HZ_6T+R75gwSF=ax-0yJZJ_rVg@mail.gmail.com>
On Mon, May 06, 2019 at 11:28:17PM +0900, Masahiro Yamada wrote:
> This patch is technically super easy,
> but shows how difficult to apply a
> single patch in a correct manner.
>
>
> The following showed up in today's linux-next,
> doubling
> "Signed-off-by: Douglas Anderson <dianders@chromium.org>"
>
> This is obviously caused by the committer.
Quite so. Thanks for pointing it out.
> Do we need some check script for maintainers
> before "git push" ?
I have to admit that I think this was just a checkpatch mistake on
my part.
This thread is a bit unusual in that patchwork has collected up
all the example Tested-by: Fred stuff that arose during the earlier
tools conversation. It looks like I was sufficiently distracted by
those to overlook the duplicated sign off...
Daniel.
> commit 51fee3389d71bfd281df02c55546a6103779e145
> Author: Douglas Anderson <dianders@chromium.org>
> AuthorDate: Fri Mar 22 18:52:27 2019 -0700
> Commit: Daniel Thompson <daniel.thompson@linaro.org>
> CommitDate: Thu May 2 14:55:07 2019 +0100
>
> kdb: Get rid of broken attempt to print CCVERSION in kdb summary
>
> If you drop into kdb and type "summary", it prints out a line that
> says this:
>
> ccversion CCVERSION
>
> ...and I don't mean that it actually prints out the version of the C
> compiler. It literally prints out the string "CCVERSION".
>
> The version of the C Compiler is already printed at boot up and it
> doesn't seem useful to replicate this in kdb. Let's just delete it.
> We can also delete the bit of the Makefile that called the C compiler
> in an attempt to pass this into kdb. This will remove one extra call
> to the C compiler at Makefile parse time and (very slightly) speed up
> builds.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> Reviewed-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
>
>
>
>
>
>
>
>
> On Sat, Apr 20, 2019 at 3:24 AM Joe Perches <joe@perches.com> wrote:
> >
> > On Fri, 2019-04-19 at 12:28 +0900, Masahiro Yamada wrote:
> > > Hi Joe,
> > >
> > > Can you detect redundant Cc: by checkpatch?
> > >
> > > Please see below in details.
> > > Thanks.
> >
> > Yes, but I'm not sure why it's useful or necessary.
> > git send-email using some scripts elides duplicate email addresses
> > ---
> > scripts/checkpatch.pl | 13 +++++++++++++
> > 1 file changed, 13 insertions(+)
> >
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> > index 1c421ac42b07..bedec83cb797 100755
> > --- a/scripts/checkpatch.pl
> > +++ b/scripts/checkpatch.pl
> > @@ -2688,6 +2688,19 @@ sub process {
> > $signatures{$sig_nospace} = 1;
> > }
> >
> > +# Check for a cc: line with another signature -by: by the same author
> > + if ($sig_nospace =~ /^cc:/) {
> > + my $sig_email = substr($sig_nospace, 3);
> > + foreach my $sig (sort keys %signatures) {
> > + next if ($sig =~ /^cc:/);
> > + $sig =~ s/^[^:]+://;
> > + if ($sig eq $sig_email) {
> > + WARN("BAD_SIGN_OFF",
> > + "Unnecessary CC: as there is another signature with the same name/email address\n" . $herecurr);
> > + }
> > + }
> > + }
> > +
> > # Check Co-developed-by: immediately followed by Signed-off-by: with same name and email
> > if ($sign_off =~ /^co-developed-by:$/i) {
> > if ($email eq $author) {
> >
> >
>
>
> --
> Best Regards
> Masahiro Yamada
prev parent reply other threads:[~2019-05-07 13:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-23 1:52 [PATCH] kdb: Get rid of broken attempt to print CCVERSION in kdb summary Douglas Anderson
2019-03-30 12:14 ` Masahiro Yamada
2019-04-11 9:06 ` Masahiro Yamada
2019-04-16 23:30 ` Andrew Morton
2019-04-17 6:37 ` Masahiro Yamada
2019-04-18 23:06 ` Andrew Morton
2019-04-19 3:28 ` Masahiro Yamada
2019-04-19 11:14 ` Joe Perches
2019-04-19 20:58 ` Andrew Morton
2019-04-20 3:57 ` Joe Perches
2019-05-06 14:28 ` Masahiro Yamada
2019-05-07 13:55 ` Daniel Thompson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190507135512.5fyy3zu7ljjaeg3u@holly.lan \
--to=daniel.thompson@linaro.org \
--cc=akpm@linux-foundation.org \
--cc=christophe.leroy@c-s.fr \
--cc=dianders@chromium.org \
--cc=gustavo@embeddedor.com \
--cc=hannes@cmpxchg.org \
--cc=hofrat@osadl.org \
--cc=jason.wessel@windriver.com \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).