From: Keith Busch <kbusch@kernel.org>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: Keith Busch <keith.busch@intel.com>, Jens Axboe <axboe@fb.com>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH] nvme-pci: mark expected switch fall-through
Date: Tue, 7 May 2019 08:21:17 -0600 [thread overview]
Message-ID: <20190507142117.GE2219@localhost.localdomain> (raw)
In-Reply-To: <20190507142300.GA25717@embeddedor>
On Tue, May 07, 2019 at 09:23:00AM -0500, Gustavo A. R. Silva wrote:
> @@ -1296,6 +1296,7 @@ static enum blk_eh_timer_return nvme_timeout(struct request *req, bool reserved)
> switch (dev->ctrl.state) {
> case NVME_CTRL_DELETING:
> shutdown = true;
> + /* fall through */
> case NVME_CTRL_CONNECTING:
> case NVME_CTRL_RESETTING:
> dev_warn_ratelimited(dev->ctrl.device,
Thanks, Looks good.
Reviewed-by: Keith Busch <keith.busch@intel.com>
next prev parent reply other threads:[~2019-05-07 14:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-07 14:23 [PATCH] nvme-pci: mark expected switch fall-through Gustavo A. R. Silva
2019-05-07 14:21 ` Keith Busch [this message]
2019-05-07 17:41 ` Chaitanya Kulkarni
2019-05-08 7:18 ` Christoph Hellwig
2019-05-08 14:51 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190507142117.GE2219@localhost.localdomain \
--to=kbusch@kernel.org \
--cc=axboe@fb.com \
--cc=gustavo@embeddedor.com \
--cc=hch@lst.de \
--cc=keescook@chromium.org \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).