From: Eric Biggers <ebiggers@kernel.org>
To: Kees Cook <keescook@chromium.org>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
Joao Moreira <jmoreira@suse.de>, Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Borislav Petkov <bp@alien8.de>,
x86@kernel.org, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org,
kernel-hardening@lists.openwall.com
Subject: Re: [PATCH v3 0/7] crypto: x86: Fix indirect function call casts
Date: Tue, 7 May 2019 10:00:41 -0700 [thread overview]
Message-ID: <20190507170039.GB1399@sol.localdomain> (raw)
In-Reply-To: <20190507161321.34611-1-keescook@chromium.org>
On Tue, May 07, 2019 at 09:13:14AM -0700, Kees Cook wrote:
> It is possible to indirectly invoke functions with prototypes that do
> not match those of the respectively used function pointers by using void
> types or casts. This feature is frequently used as a way of relaxing
> function invocation, making it possible that different data structures
> are passed to different functions through the same pointer.
>
> Despite the benefits, this can lead to a situation where functions with a
> given prototype are invoked by pointers with a different prototype. This
> is undesirable as it may prevent the use of heuristics such as prototype
> matching-based Control-Flow Integrity, which can be used to prevent
> ROP-based attacks.
>
> One way of fixing this situation is through the use of inline helper
> functions with prototypes that match the one in the respective invoking
> pointer.
>
> Given the above, the current efforts to improve the Linux security,
> and the upcoming kernel support to compilers with CFI features, this
> creates macros to be used to build the needed function definitions,
> to be used in camellia, cast6, serpent, twofish, and aesni.
So why not change the function prototypes to be compatible with common_glue_*_t
instead, rather than wrapping them with another layer of functions? Is it
because indirect calls into asm code won't be allowed with CFI?
>
> -Kees (and Joao)
>
> v3:
> - no longer RFC
> - consolidate macros into glue_helper.h
> - include aesni which was using casts as well
> - remove XTS_TWEAK_CAST while we're at it
>
> v2:
> - update cast macros for clarity
>
> v1:
> - initial prototype
>
> Joao Moreira (4):
> crypto: x86/crypto: Use new glue function macros
This one should be "x86/serpent", not "x86/crypto".
> crypto: x86/camellia: Use new glue function macros
> crypto: x86/twofish: Use new glue function macros
> crypto: x86/cast6: Use new glue function macros
>
> Kees Cook (3):
> crypto: x86/glue_helper: Add static inline function glue macros
> crypto: x86/aesni: Use new glue function macros
> crypto: x86/glue_helper: Remove function prototype cast helpers
>
> arch/x86/crypto/aesni-intel_glue.c | 31 ++++-----
> arch/x86/crypto/camellia_aesni_avx2_glue.c | 73 +++++++++-------------
> arch/x86/crypto/camellia_aesni_avx_glue.c | 63 +++++++------------
> arch/x86/crypto/camellia_glue.c | 21 +++----
> arch/x86/crypto/cast6_avx_glue.c | 65 +++++++++----------
> arch/x86/crypto/serpent_avx2_glue.c | 65 +++++++++----------
> arch/x86/crypto/serpent_avx_glue.c | 58 ++++++-----------
> arch/x86/crypto/serpent_sse2_glue.c | 27 +++++---
> arch/x86/crypto/twofish_avx_glue.c | 71 ++++++++-------------
> arch/x86/crypto/twofish_glue_3way.c | 28 ++++-----
> arch/x86/include/asm/crypto/camellia.h | 64 ++++++-------------
> arch/x86/include/asm/crypto/glue_helper.h | 34 ++++++++--
> arch/x86/include/asm/crypto/serpent-avx.h | 28 ++++-----
> arch/x86/include/asm/crypto/twofish.h | 22 ++++---
> include/crypto/xts.h | 2 -
> 15 files changed, 283 insertions(+), 369 deletions(-)
>
> --
> 2.17.1
>
next prev parent reply other threads:[~2019-05-07 17:00 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-07 16:13 [PATCH v3 0/7] crypto: x86: Fix indirect function call casts Kees Cook
2019-05-07 16:13 ` [PATCH v3 1/7] crypto: x86/glue_helper: Add static inline function glue macros Kees Cook
2019-05-07 16:13 ` [PATCH v3 2/7] crypto: x86/crypto: Use new glue function macros Kees Cook
2019-05-07 16:13 ` [PATCH v3 3/7] crypto: x86/camellia: " Kees Cook
2019-05-07 16:13 ` [PATCH v3 4/7] crypto: x86/twofish: " Kees Cook
2019-05-07 16:13 ` [PATCH v3 5/7] crypto: x86/cast6: " Kees Cook
2019-05-07 16:13 ` [PATCH v3 6/7] crypto: x86/aesni: " Kees Cook
2019-05-07 16:13 ` [PATCH v3 7/7] crypto: x86/glue_helper: Remove function prototype cast helpers Kees Cook
2019-05-07 17:00 ` Eric Biggers [this message]
2019-05-07 21:07 ` [PATCH v3 0/7] crypto: x86: Fix indirect function call casts Kees Cook
2019-05-07 21:50 ` Eric Biggers
2019-05-08 13:36 ` Herbert Xu
2019-05-08 21:08 ` Kees Cook
2019-05-09 1:39 ` Herbert Xu
2019-05-09 2:04 ` Eric Biggers
2019-05-09 3:12 ` Joao Moreira
2019-05-09 3:16 ` Herbert Xu
2019-05-09 15:38 ` Sami Tolvanen
2019-05-09 17:58 ` Eric Biggers
2019-05-09 19:27 ` Sami Tolvanen
2019-05-09 1:53 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190507170039.GB1399@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=bp@alien8.de \
--cc=herbert@gondor.apana.org.au \
--cc=jmoreira@suse.de \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).