From: Paul Cercueil <paul@crapouillou.net>
To: Ralf Baechle <ralf@linux-mips.org>,
Paul Burton <paul.burton@mips.com>,
James Hogan <jhogan@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>
Cc: od@zcrc.me, linux-mips@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
Paul Cercueil <paul@crapouillou.net>
Subject: [PATCH 3/5] MIPS: jz4740: PM: Let CGU driver suspend clocks and set sleep mode
Date: Tue, 7 May 2019 21:34:19 +0200 [thread overview]
Message-ID: <20190507193421.12260-3-paul@crapouillou.net> (raw)
In-Reply-To: <20190507193421.12260-1-paul@crapouillou.net>
Instead of forcing the jz4740 clocks to suspend here, we let the CGU
driver handle it.
We also let the CGU driver set the "sleep mode" bit.
This has the added benefit that now it is possible to build a kernel on
SoCs newer than the JZ4740 with CONFIG_PM.
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---
arch/mips/jz4740/pm.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/arch/mips/jz4740/pm.c b/arch/mips/jz4740/pm.c
index 2d8653f2fc61..9e6c7a2b955f 100644
--- a/arch/mips/jz4740/pm.c
+++ b/arch/mips/jz4740/pm.c
@@ -18,21 +18,13 @@
#include <linux/delay.h>
#include <linux/suspend.h>
-#include <asm/mach-jz4740/clock.h>
-
static int jz4740_pm_enter(suspend_state_t state)
{
- jz4740_clock_suspend();
-
- jz4740_clock_set_wait_mode(JZ4740_WAIT_MODE_SLEEP);
-
__asm__(".set\tmips3\n\t"
"wait\n\t"
".set\tmips0");
- jz4740_clock_set_wait_mode(JZ4740_WAIT_MODE_IDLE);
- jz4740_clock_resume();
return 0;
}
--
2.21.0.593.g511ec345e18
next prev parent reply other threads:[~2019-05-07 19:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-07 19:34 [PATCH 1/5] clk: ingenic: Add missing header in cgu.h Paul Cercueil
2019-05-07 19:34 ` [PATCH 2/5] clk: ingenic: Handle setting the Low-Power Mode bit Paul Cercueil
2019-05-07 19:34 ` Paul Cercueil [this message]
2019-05-07 19:34 ` [PATCH 4/5] clk: ingenic: Remove unused functions Paul Cercueil
2019-05-07 19:34 ` [PATCH 5/5] MIPS: Remove dead code Paul Cercueil
2019-05-07 20:19 ` [PATCH 1/5] clk: ingenic: Add missing header in cgu.h Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190507193421.12260-3-paul@crapouillou.net \
--to=paul@crapouillou.net \
--cc=jhogan@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=od@zcrc.me \
--cc=paul.burton@mips.com \
--cc=ralf@linux-mips.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).