From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_NEOMUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FE62C04AAD for ; Tue, 7 May 2019 20:02:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2E9B820449 for ; Tue, 7 May 2019 20:02:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726751AbfEGUCx (ORCPT ); Tue, 7 May 2019 16:02:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50269 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726091AbfEGUCx (ORCPT ); Tue, 7 May 2019 16:02:53 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5C98F308793F; Tue, 7 May 2019 20:02:52 +0000 (UTC) Received: from treble (ovpn-123-166.rdu2.redhat.com [10.10.123.166]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 23D29600D4; Tue, 7 May 2019 20:02:46 +0000 (UTC) Date: Tue, 7 May 2019 15:02:44 -0500 From: Josh Poimboeuf To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, Linus Torvalds , Peter Zijlstra , Andy Lutomirski , Ingo Molnar , Andrew Morton , Andy Lutomirski , Nicolai Stange , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , the arch/x86 maintainers , Jiri Kosina , Miroslav Benes , Petr Mladek , Joe Lawrence , Shuah Khan , Konrad Rzeszutek Wilk , Tim Chen , Sebastian Andrzej Siewior , Mimi Zohar , Juergen Gross , Nick Desaulniers , Nayna Jain , Masahiro Yamada , Joerg Roedel , "open list:KERNEL SELFTEST FRAMEWORK" , stable , Masami Hiramatsu Subject: Re: [RFC][PATCH 2/3] x86_64: Allow breakpoints to emulate call functions Message-ID: <20190507200244.mo6po3xxdg3kv2xy@treble> References: <20190507174227.673261270@goodmis.org> <20190507174400.219947724@goodmis.org> <20190507175342.fskdj2qidpao65qi@treble> <20190507150153.7a5d376d@gandalf.local.home> <20190507191412.n4uhoyfwagagyfwi@treble> <20190507152016.77f7a3af@gandalf.local.home> <20190507194925.qndvv67rinrmbefj@treble> <20190507155817.2d08d0eb@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190507155817.2d08d0eb@gandalf.local.home> User-Agent: NeoMutt/20180716 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Tue, 07 May 2019 20:02:52 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 07, 2019 at 03:58:17PM -0400, Steven Rostedt wrote: > On Tue, 7 May 2019 14:49:25 -0500 > Josh Poimboeuf wrote: > > > > New version: > > > > > > x86_64: Allow breakpoints to emulate call functions > > > > > > In order to allow breakpoints to emulate call functions, they need to push > > > > Sorry to keep nitpicking, but "call functions" -> "function calls" would > > sound more accurate to me (in both subject and description). > > I disagree ;-) > > Matters how you look at it. I look at it as emulating the "call" > function, not a function call. Like emulating an "addl" function, or a > "jmp" function. > > See? I kind of see your point... but then you're overloading the meaning of the word "function", in a context where it clearly means something else. > To remove the ambiguity, I could replace "function" with "instruction". Yes, that would be much better :-) -- Josh