From: Greg KH <gregkh@linuxfoundation.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Andrew Morton <akpm@linux-foundation.org>,
Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
devel@linuxdriverproject.org
Subject: Re: [GIT PULL] Staging/IIO driver patches for 5.2-rc1
Date: Wed, 8 May 2019 11:49:29 +0200 [thread overview]
Message-ID: <20190508094929.GC6996@kroah.com> (raw)
In-Reply-To: <CAHk-=wg+w5+vAo1DQrprSG8APptZ5-Kek4NL_mnr9p08vFyQrg@mail.gmail.com>
On Tue, May 07, 2019 at 01:33:06PM -0700, Linus Torvalds wrote:
> On Tue, May 7, 2019 at 10:59 AM Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > All of these have been in linux-next for a while with no reported
> > issues, other than an odd gcc warning for one of the new drivers that
> > should be fixed up soon.
>
> Ok, that's truly a funky warning.
>
> But since I don't deal well with warnings, particularly during the
> merge window, I just fixed it up in the merge.
>
> The fix is to simply not have a bitfield base type of "unsigned char",
> and have it cross a char boundary. Instead the base type should just
> be "unsigned int".
Ah, that's how to resolve that, thanks, it wasn't obvious at all from
the odd gcc warning.
> Of course, I couldn't test my change, but it shuts the compiler up,
> and it very much looks like the right thing.
The driver author can test it out, given that it needs loads of work
anyway, whatever you did to it is fine :)
thanks,
greg k-h
next prev parent reply other threads:[~2019-05-08 9:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-07 17:58 [GIT PULL] Staging/IIO driver patches for 5.2-rc1 Greg KH
2019-05-07 18:01 ` Greg KH
2019-05-07 20:33 ` Linus Torvalds
2019-05-08 9:49 ` Greg KH [this message]
2019-05-07 20:50 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190508094929.GC6996@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=devel@linuxdriverproject.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).