From: Herbert Xu <herbert@gondor.apana.org.au>
To: Neal Liu <neal.liu@mediatek.com>
Cc: Stephan Mueller <smueller@chronox.de>,
mpm@selenic.com, robh+dt@kernel.org, mark.rutland@arm.com,
matthias.bgg@gmail.com, wsd_upstream@mediatek.com,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org,
Crystal.Guo@mediatek.com
Subject: Re: [PATCH 3/3] hwrng: add mt67xx-rng driver
Date: Thu, 9 May 2019 13:26:49 +0800 [thread overview]
Message-ID: <20190509052649.xfkgb3qd7rhcgktj@gondor.apana.org.au> (raw)
In-Reply-To: <1557311737.11818.11.camel@mtkswgap22>
On Wed, May 08, 2019 at 06:35:37PM +0800, Neal Liu wrote:
> Hi Stephan,
> We think the cast is fine, and it cannot guarantee the buf is
> word-align.
> I reference multiple rng driver's implementation and found it's common
> usage for this. So it might be general usage for community. Is there any
> suggestion that is more appropriate?
If you don't know whether it's unaligned or not then you should
do an unaligned operation.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2019-05-09 5:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-08 3:58 [PATCH 0/3] MT67XX random number generator support neal.liu
2019-05-08 3:58 ` [PATCH 1/3] soc: mediatek: add SMC fid table for SIP interface neal.liu
2019-05-08 3:58 ` [PATCH 2/3] dt-bindings: rng: update bindings for MT67xx SoCs neal.liu
2019-05-08 3:58 ` [PATCH 3/3] hwrng: add mt67xx-rng driver neal.liu
2019-05-08 6:34 ` Stephan Mueller
2019-05-08 10:35 ` Neal Liu
2019-05-09 5:26 ` Herbert Xu [this message]
2019-05-09 14:54 ` Neal Liu
2019-05-10 6:39 ` Herbert Xu
2019-05-24 7:42 ` Neal Liu
2019-05-24 12:55 ` Herbert Xu
2019-05-24 19:00 ` Sean Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190509052649.xfkgb3qd7rhcgktj@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=Crystal.Guo@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=mpm@selenic.com \
--cc=neal.liu@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=smueller@chronox.de \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).