From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
LKML <linux-kernel@vger.kernel.org>,
Daniel Vetter <daniel.vetter@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Valdis Kletnieks <valdis.kletnieks@vt.edu>,
Laurence Oberman <loberman@redhat.com>,
Vincent Whitchurch <vincent.whitchurch@axis.com>,
Don Zickus <dzickus@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Sinan Kaya <okaya@kernel.org>
Subject: Re: [PATCH 2/2] RFC: soft/hardlookup: taint kernel
Date: Thu, 9 May 2019 18:24:49 +0900 [thread overview]
Message-ID: <20190509092449.GA10828@jagdpanzerIV> (raw)
In-Reply-To: <20190502194208.3535-2-daniel.vetter@ffwll.ch>
On (05/02/19 21:42), Daniel Vetter wrote:
[..]
> @@ -469,6 +469,8 @@ static enum hrtimer_restart watchdog_timer_fn(struct hrtimer *hrtimer)
> add_taint(TAINT_SOFTLOCKUP, LOCKDEP_STILL_OK);
> if (softlockup_panic)
> panic("softlockup: hung tasks");
> + else
> + add_taint(TAINT_WARN, LOCKDEP_STILL_OK);
> __this_cpu_write(soft_watchdog_warn, true);
Soft lockup sets TAINT_SOFTLOCKUP bit. Would it be enough for your CI?
[..]
> @@ -154,6 +154,8 @@ static void watchdog_overflow_callback(struct perf_event *event,
>
> if (hardlockup_panic)
> nmi_panic(regs, "Hard LOCKUP");
> + else
> + add_taint(TAINT_WARN, LOCKDEP_STILL_OK);
Maybe you can mirror what soft lockup does. Add a HARDLOCKUP taint bit
+++ b/include/linux/kernel.h
@@ -571,7 +571,8 @@ extern enum system_states {
#define TAINT_LIVEPATCH 15
#define TAINT_AUX 16
#define TAINT_RANDSTRUCT 17
-#define TAINT_FLAGS_COUNT 18
+#define TAINT_HARDLOCKUP 18
+#define TAINT_FLAGS_COUNT 19
and then set TAINT_HARDLOCKUP in watchdog_overflow_callback().
Just a small idea, I'll leave this to more experienced people.
-ss
next prev parent reply other threads:[~2019-05-09 9:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-02 19:42 [PATCH 1/2] RFC: hung_task: taint kernel Daniel Vetter
2019-05-02 19:42 ` [PATCH 2/2] RFC: soft/hardlookup: " Daniel Vetter
2019-05-03 0:00 ` Laurence Oberman
2019-05-09 9:24 ` Sergey Senozhatsky [this message]
2019-05-09 10:16 ` Daniel Vetter
2019-05-02 20:46 ` [PATCH] RFC: hung_task: " Daniel Vetter
2019-05-03 0:47 ` Tetsuo Handa
2019-05-03 8:51 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190509092449.GA10828@jagdpanzerIV \
--to=sergey.senozhatsky.work@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dzickus@redhat.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loberman@redhat.com \
--cc=mingo@kernel.org \
--cc=okaya@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=valdis.kletnieks@vt.edu \
--cc=vincent.whitchurch@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).