From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28B78C04AB1 for ; Thu, 9 May 2019 18:45:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F37602183F for ; Thu, 9 May 2019 18:45:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557427556; bh=aN7zUq/E67UrnccRwoLh33vhd9zhbZEvz7Rksp36vrc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=IKYTClLfmNu7yLZoQ+y1R24GtnQemmVwLpDdSuZJN1EYzqhtS2PVuXy4ijFnEUAGX hZOYMvNLRyypnVnyMSAXDPt/lNo5qE8rTx2sey/cjXjwMNSFP/TDtmHsN/AlcHytbW 9YmkJDkoyjC8aLcOPwlRpD4joKBYEQ0FGq6LINqk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726952AbfEISpz (ORCPT ); Thu, 9 May 2019 14:45:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:37808 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726903AbfEISpt (ORCPT ); Thu, 9 May 2019 14:45:49 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6E2762182B; Thu, 9 May 2019 18:45:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557427548; bh=aN7zUq/E67UrnccRwoLh33vhd9zhbZEvz7Rksp36vrc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=r8Dbf1a5ZuwCQS3PTyBQvFdNrKSheOkRMQO6N/E2vNt+A4TRVBPpcpODjHDT+u/p2 ELNl11ZzN0yalUmLL6ZssGFjceJB3fugeWaT2BpUkGhzqTcw5OsrxG+X3tRdJNje00 im5Zswni8dYP/IdC1PlQ3bgyYcb2E6ll+45u+gJE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Kamal Heib , Adit Ranadive , Jason Gunthorpe , Sasha Levin Subject: [PATCH 4.14 23/42] RDMA/vmw_pvrdma: Fix memory leak on pvrdma_pci_remove Date: Thu, 9 May 2019 20:42:12 +0200 Message-Id: <20190509181257.358644909@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190509181252.616018683@linuxfoundation.org> References: <20190509181252.616018683@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit ea7a5c706fa49273cf6d1d9def053ecb50db2076 ] Make sure to free the DSR on pvrdma_pci_remove() to avoid the memory leak. Fixes: 29c8d9eba550 ("IB: Add vmw_pvrdma driver") Signed-off-by: Kamal Heib Acked-by: Adit Ranadive Signed-off-by: Jason Gunthorpe Signed-off-by: Sasha Levin --- drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c b/drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c index 6ce709a67959b..d549c9ffadcbb 100644 --- a/drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c +++ b/drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c @@ -1055,6 +1055,8 @@ static void pvrdma_pci_remove(struct pci_dev *pdev) pvrdma_page_dir_cleanup(dev, &dev->cq_pdir); pvrdma_page_dir_cleanup(dev, &dev->async_pdir); pvrdma_free_slots(dev); + dma_free_coherent(&pdev->dev, sizeof(*dev->dsr), dev->dsr, + dev->dsrbase); iounmap(dev->regs); kfree(dev->sgid_tbl); -- 2.20.1