From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63E2CC04A6B for ; Fri, 10 May 2019 13:58:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2CC0C21479 for ; Fri, 10 May 2019 13:58:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557496685; bh=wi9DrMR6mkrZM1IxX0zmeg7ZN7IjGhBRej4ymYmI7tY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=s7KkJF/ebsaoQr8d1MppAioUzTzcNXtFRsO9iIkN1L+7RfDaKSeXqu17rnorBZGm8 Yq/5rrpL75xSo3RN7ySmJgadHDbKdOD86EWWMao98TLxfpVkVZiS+UtFyiLFw13B/4 haSVckv1maWYrlOE+G3VCVi13igdSn0nVbCH4Rag= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727853AbfEJN6E (ORCPT ); Fri, 10 May 2019 09:58:04 -0400 Received: from mga06.intel.com ([134.134.136.31]:18693 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727425AbfEJN6D (ORCPT ); Fri, 10 May 2019 09:58:03 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 May 2019 06:58:03 -0700 X-ExtLoop1: 1 Received: from unknown (HELO localhost.localdomain) ([10.232.112.69]) by orsmga001.jf.intel.com with ESMTP; 10 May 2019 06:58:02 -0700 Date: Fri, 10 May 2019 07:52:34 -0600 From: Keith Busch To: "Rafael J. Wysocki" Cc: Kai-Heng Feng , Mario Limonciello , Christoph Hellwig , Jens Axboe , Sagi Grimberg , Linux PM , "Wysocki, Rafael J" , Linux Kernel Mailing List , linux-nvme , "Busch, Keith" Subject: Re: [PATCH] nvme-pci: Use non-operational power state instead of D3 on Suspend-to-Idle Message-ID: <20190510135234.GF9675@localhost.localdomain> References: <225CF4F7-C8E1-4C66-B362-97E84596A54E@canonical.com> <20190509103142.GA19550@lst.de> <31b7d7959bf94c15a04bab0ced518444@AUSX13MPC101.AMER.DELL.COM> <20190509192807.GB9675@localhost.localdomain> <7a002851c435481593f8629ec9193e40@AUSX13MPC101.AMER.DELL.COM> <20190509215409.GD9675@localhost.localdomain> <495d76c66aec41a8bfbbf527820f8eb9@AUSX13MPC101.AMER.DELL.COM> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 10, 2019 at 01:23:11AM -0700, Rafael J. Wysocki wrote: > On Fri, May 10, 2019 at 8:08 AM Kai-Heng Feng > > I tested the patch from Keith and it has two issues just as simply skipping > > nvme_dev_disable(): > > 1) It consumes more power in S2I > > 2) System freeze after resume > > Well, the Keith's patch doesn't prevent pci_pm_suspend_noirq() from > asking for D3 and both of the symptoms above may be consequences of > that in principle. Right, I'll fix up the kernel's PCI D3 control and resend for consideration.