From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AE8FC04AB3 for ; Fri, 10 May 2019 20:11:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 05DD5217F9 for ; Fri, 10 May 2019 20:11:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728036AbfEJULs (ORCPT ); Fri, 10 May 2019 16:11:48 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:40221 "EHLO relay6-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727676AbfEJULr (ORCPT ); Fri, 10 May 2019 16:11:47 -0400 X-Originating-IP: 90.66.53.80 Received: from localhost (lfbn-1-3034-80.w90-66.abo.wanadoo.fr [90.66.53.80]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id F2EA7C0002; Fri, 10 May 2019 20:11:43 +0000 (UTC) Date: Fri, 10 May 2019 22:11:43 +0200 From: Alexandre Belloni To: Claudiu.Beznea@microchip.com Cc: mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, Nicolas.Ferre@microchip.com, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/4] clk: at91: sckc: sama5d4 has no bypass support Message-ID: <20190510201143.GC7622@piout.net> References: <1557487388-32098-1-git-send-email-claudiu.beznea@microchip.com> <1557487388-32098-2-git-send-email-claudiu.beznea@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1557487388-32098-2-git-send-email-claudiu.beznea@microchip.com> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/05/2019 11:23:27+0000, Claudiu.Beznea@microchip.com wrote: > From: Claudiu Beznea > > The slow clock of SAMA5D4 has no bypass support thus remove it. > > Signed-off-by: Claudiu Beznea Acked-by: Alexandre Belloni > --- > drivers/clk/at91/sckc.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/clk/at91/sckc.c b/drivers/clk/at91/sckc.c > index e76b1d64e905..6c55a7a86f79 100644 > --- a/drivers/clk/at91/sckc.c > +++ b/drivers/clk/at91/sckc.c > @@ -429,7 +429,6 @@ static void __init of_sama5d4_sckc_setup(struct device_node *np) > struct clk_init_data init; > const char *xtal_name; > const char *parent_names[2] = { "slow_rc_osc", "slow_osc" }; > - bool bypass; > int ret; > > if (!regbase) > @@ -443,8 +442,6 @@ static void __init of_sama5d4_sckc_setup(struct device_node *np) > > xtal_name = of_clk_get_parent_name(np, 0); > > - bypass = of_property_read_bool(np, "atmel,osc-bypass"); > - > osc = kzalloc(sizeof(*osc), GFP_KERNEL); > if (!osc) > return; > @@ -459,9 +456,6 @@ static void __init of_sama5d4_sckc_setup(struct device_node *np) > osc->sckcr = regbase; > osc->startup_usec = 1200000; > > - if (bypass) > - writel((readl(regbase) | AT91_SCKC_OSC32BYP), regbase); > - > hw = &osc->hw; > ret = clk_hw_register(NULL, &osc->hw); > if (ret) { > -- > 2.7.4 > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com