From: "Tobin C. Harding" <tobin@kernel.org>
To: Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>
Cc: "Tobin C. Harding" <tobin@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 0/2] Fix kobject error path memleaks
Date: Mon, 13 May 2019 13:39:10 +1000 [thread overview]
Message-ID: <20190513033912.3436-1-tobin@kernel.org> (raw)
Hi,
Is it ok to send patches during the merge window? Applies on top of
Linus' mainline tag: v5.1, happy to rebase if there are conflicts.
While auditing kobject_init_and_add() calls throughout the kernel it was
found that btrfs potentially has a couple of memleaks in the error path
code for kobject_init_and_add().
Failing calls to kobject_init_and_add() should be followed by a call to
kobject_put() since kobject_init_and_add() always calls kobject_init().
Of note, adding kobject_put() causes the release method to be called if
kobject_init_and_add() fails. For patch #1 this means we don't have to
manually free the space_info or call percpu_counter_destroy() since
these are both done by the release method. In the second patch, I
believe the added call to kobject_put() fits in with the fs_devices
lifecycle assumptions of open_ctree() but please could you review since
I am new to this code.
CC'ing the kobject maintainers/reviewers also.
Thanks,
Tobin.
Tobin C. Harding (2):
fs: btrfs: Fix error path kobject memory leak
fs: btrfs: Don't leak memory when failing add fsid
fs/btrfs/extent-tree.c | 3 +--
fs/btrfs/sysfs.c | 7 ++++++-
2 files changed, 7 insertions(+), 3 deletions(-)
--
2.21.0
next reply other threads:[~2019-05-13 3:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-13 3:39 Tobin C. Harding [this message]
2019-05-13 3:39 ` [PATCH 1/2] fs: btrfs: Fix error path kobject memory leak Tobin C. Harding
2019-05-13 5:59 ` Nikolay Borisov
2019-05-13 7:11 ` Greg Kroah-Hartman
2019-05-13 3:39 ` [PATCH 2/2] fs: btrfs: Don't leak memory when failing add fsid Tobin C. Harding
2019-05-13 6:04 ` Nikolay Borisov
2019-05-13 10:57 ` Tobin C. Harding
2019-05-13 7:12 ` Greg Kroah-Hartman
2019-05-13 17:47 ` [PATCH 0/2] Fix kobject error path memleaks David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190513033912.3436-1-tobin@kernel.org \
--to=tobin@kernel.org \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=gregkh@linuxfoundation.org \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).