From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63FFFC04AB1 for ; Mon, 13 May 2019 14:49:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 369062133F for ; Mon, 13 May 2019 14:49:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=poorly.run header.i=@poorly.run header.b="eNRYCOI4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730939AbfEMOt2 (ORCPT ); Mon, 13 May 2019 10:49:28 -0400 Received: from mail-qt1-f193.google.com ([209.85.160.193]:45010 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728280AbfEMOt2 (ORCPT ); Mon, 13 May 2019 10:49:28 -0400 Received: by mail-qt1-f193.google.com with SMTP id f24so10607947qtk.11 for ; Mon, 13 May 2019 07:49:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=poorly.run; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=f57f9CrkLHcFePwjN3FU4Rm5r4Irtea70kxXmHOLUco=; b=eNRYCOI4Cpe7VbMGN3Mij1vUAro3bwftdHrWDAXGJjKa4FxsC20E1IR4yp7rfJaHgU NFr4NGb/l8gYtiWC5t8U/QmKwQkIJoFMioynbUv5GiZA2XPvw4SPpiFgyXeCpt8+F+lc HQb53Xpc7qcpSry382HT166WeDmlRPNZLhytbJcbIs6NClgbtS3OZrV7lu3f76a30aVC OuSheK4Wo5RMbkTM3Xcpizy9fWOQzk34+h9Olt6u+E1S1PgFoAsAyFjTn7laW+wDx3YT H+KU9HdNYmUU6r0NjsuV4y2SFvsKbLPSKNIV1VFTFzILwwtNfqsaKnQTy4Qm80iidvhk 7Igw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=f57f9CrkLHcFePwjN3FU4Rm5r4Irtea70kxXmHOLUco=; b=dzLUmFxCZfP0Sto2BwYo61xtnH3DGVFGHCZhY5+2G7RYvu9MhaJeP7RaDVSjCbBKpz JsFK+dwM6lVW2gStx9E7jYq/FJKUvhBcnCMT4XyQvj4B77g4nKNfOb6XeZhCZJ028QqK GpwgVmxSBiLkFxtYkZGf83b+ad/q5YZL/DBhm1wjiJoh0wcK0QbnIn2w/p3yF2Ztz6S8 0P8QNDpCCDNpwsfgfSwkGLz4hI370ECeV1qW+8fuJn8XIkA1Dff3LZ5wBCZWATXnzDvK YdvYJPQoFNz6pKOa+V+vLPyUlh3aRV+77bBh3UYRnEmYHiEr7hppBxPd27HzSSmlhW8H 8YQQ== X-Gm-Message-State: APjAAAUIlyOm94GMNeaZQwDBSbZ60GwlvPiuL51XAg7wCgwofgfT8yPH RQvJut27uorDUgc2NGXeGPH9vg== X-Google-Smtp-Source: APXvYqzkJCxySOotyEccUkLJnh8/L72NsFkDS7twtnhdQDc/s7sFH4Ei7ug85zyIi2vDurk31ZYd4Q== X-Received: by 2002:ac8:33bc:: with SMTP id c57mr23963559qtb.252.1557758967170; Mon, 13 May 2019 07:49:27 -0700 (PDT) Received: from localhost ([2620:0:1013:11:89c6:2139:5435:371d]) by smtp.gmail.com with ESMTPSA id g206sm6871504qkb.75.2019.05.13.07.49.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 13 May 2019 07:49:26 -0700 (PDT) Date: Mon, 13 May 2019 10:49:26 -0400 From: Sean Paul To: Rob Clark Cc: dri-devel@lists.freedesktop.org, Georgi Djakov , Rob Clark , Sean Paul , David Airlie , Daniel Vetter , linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/5] drm/msm/mdp5: Use the interconnect API Message-ID: <20190513144926.GQ17077@art_vandelay> References: <20190508204219.31687-1-robdclark@gmail.com> <20190508204219.31687-6-robdclark@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190508204219.31687-6-robdclark@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 08, 2019 at 01:42:15PM -0700, Rob Clark wrote: > From: Georgi Djakov > > Signed-off-by: Georgi Djakov > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c > index 97179bec8902..54d2b4c2b09f 100644 > --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c > +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c > @@ -16,6 +16,7 @@ > * this program. If not, see . > */ > > +#include > #include > > #include "msm_drv.h" > @@ -1050,6 +1051,19 @@ static const struct component_ops mdp5_ops = { > > static int mdp5_dev_probe(struct platform_device *pdev) > { > + struct icc_path *path0 = of_icc_get(&pdev->dev, "port0"); > + struct icc_path *path1 = of_icc_get(&pdev->dev, "port1"); > + struct icc_path *path_rot = of_icc_get(&pdev->dev, "rotator"); > + > + if (IS_ERR(path0)) Same comments here re: NULL value > + return PTR_ERR(path0); > + icc_set_bw(path0, 0, MBps_to_icc(6400)); > + > + if (!IS_ERR(path1)) > + icc_set_bw(path1, 0, MBps_to_icc(6400)); > + if (!IS_ERR(path_rot)) > + icc_set_bw(path_rot, 0, MBps_to_icc(6400)); > + > DBG(""); > return component_add(&pdev->dev, &mdp5_ops); > } > -- > 2.20.1 > -- Sean Paul, Software Engineer, Google / Chromium OS