From: Rob Herring <robh@kernel.org>
To: Sagar Shrikant Kadam <sagar.kadam@sifive.com>
Cc: mark.rutland@arm.com, peter@korsgaard.com, andrew@lunn.ch,
palmer@sifive.com, paul.walmsley@sifive.com,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 v2 1/3] dt-bindings: i2c: extend existing opencore bindings.
Date: Mon, 13 May 2019 15:56:15 -0500 [thread overview]
Message-ID: <20190513205615.GA5844@bogus> (raw)
In-Reply-To: <1557242108-13580-2-git-send-email-sagar.kadam@sifive.com>
On Tue, May 07, 2019 at 08:45:06PM +0530, Sagar Shrikant Kadam wrote:
> Add FU540-C000 specific device tree bindings to already
> available i2-ocores file. This device is available on
> HiFive Unleashed Rev A00 board.
>
> Signed-off-by: Sagar Shrikant Kadam <sagar.kadam@sifive.com>
> ---
> Documentation/devicetree/bindings/i2c/i2c-ocores.txt | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-ocores.txt b/Documentation/devicetree/bindings/i2c/i2c-ocores.txt
> index 17bef9a..f6bcf90 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-ocores.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-ocores.txt
> @@ -2,6 +2,7 @@ Device tree configuration for i2c-ocores
>
> Required properties:
> - compatible : "opencores,i2c-ocores" or "aeroflexgaisler,i2cmst"
> + "sifive,fu540-c000-i2c" or "sifive,i2c0"
If this is Opencores IP, does it really follow the Sifive versioning
convention? If so, please reference sifive-blocks-ip-versioning.txt
(which appears to have missed going upstream). Also, referencing the IP
repository would be good too. If this IP block doesn't follow the same
convention, then don't try using it for this binding.
> - reg : bus address start and address range size of device
> - interrupts : interrupt number
> - clocks : handle to the controller clock; see the note below.
> @@ -67,3 +68,22 @@ or
> reg = <0x60>;
> };
> };
> +or
Just a new compatible isn't really a reason to add an example.
> + /*
> + An Opencore based I2C node in FU540-C000 chip from SiFive
> + This chip has a hardware erratum for broken IRQ
> + so it's recommended not to define interrupt in the device node
Then interrupts needs to be optional.
> + */
> + i2c@10030000 {
> + compatible = "sifive,i2c0","sifive,fu540-c000-i2c";
> + reg = <0x0 0x10030000 0x0 0x1000>;
> + reg-names = "i2c-control";
Not doucmented.
> + clocks = <&tlclk>;
> + clock-frequency = <100000>;
> +
> + reg-shift = <2>;
> + reg-io-width = <1>;
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> + };
> --
> 1.9.1
>
>
> --
> The information transmitted is intended only for the person or entity to
> which it is addressed and may contain confidential and/or privileged
> material. If you are not the intended recipient of this message please do
> not read, copy, use or disclose this communication and notify the sender
> immediately. It should be noted that any review, retransmission,
> dissemination or other use of, or taking action or reliance upon, this
> information by persons or entities other than the intended recipient is
> prohibited.
next prev parent reply other threads:[~2019-05-13 20:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-07 15:15 [PATCH v2 v2 0/3] Extend dt bindings to support I2C on sifive devices and a fix broken IRQ in polling mode Sagar Shrikant Kadam
2019-05-07 15:15 ` [PATCH v2 v2 1/3] dt-bindings: i2c: extend existing opencore bindings Sagar Shrikant Kadam
2019-05-07 15:24 ` Andrew Lunn
2019-05-13 20:56 ` Rob Herring [this message]
2019-05-14 12:50 ` Sagar Kadam
2019-05-14 13:01 ` Andrew Lunn
2019-05-14 16:05 ` Rob Herring
2019-05-07 15:15 ` [PATCH v2 v2 2/3] i2c-ocore: sifive: add support for i2c device on FU540-c000 SoC Sagar Shrikant Kadam
2019-05-07 15:26 ` Andrew Lunn
2019-05-07 15:15 ` [PATCH v2 v2 3/3] i2c-ocores: sifive: add polling mode workaround for FU540-C000 SoC Sagar Shrikant Kadam
2019-05-07 15:27 ` [PATCH v2 v2 0/3] Extend dt bindings to support I2C on sifive devices and a fix broken IRQ in polling mode Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190513205615.GA5844@bogus \
--to=robh@kernel.org \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
--cc=peter@korsgaard.com \
--cc=sagar.kadam@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).