From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sabyasachi Gupta <sabyasachi.linux@gmail.com>
Cc: architt@codeaurora.org, a.hajda@samsung.com, airlied@linux.ie,
jrdr.linux@gmail.com, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/bridge: Remove duplicate header
Date: Tue, 14 May 2019 10:35:42 +0300 [thread overview]
Message-ID: <20190514073542.GA4969@pendragon.ideasonboard.com> (raw)
In-Reply-To: <5cda6ee2.1c69fb81.2949b.d3e7@mx.google.com>
Hi Sabyasachi,
Thank you for the patch.
On Tue, May 14, 2019 at 01:01:41PM +0530, Sabyasachi Gupta wrote:
> Remove drm/drm_panel.h which is included more than once
>
> Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@gmail.com>
> ---
> drivers/gpu/drm/bridge/panel.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c
> index 7cbaba2..402b318 100644
> --- a/drivers/gpu/drm/bridge/panel.c
> +++ b/drivers/gpu/drm/bridge/panel.c
> @@ -15,7 +15,6 @@
> #include <drm/drm_crtc_helper.h>
> #include <drm/drm_encoder.h>
> #include <drm/drm_modeset_helper_vtables.h>
> -#include <drm/drm_panel.h>
Which tree is this against ? The patch applies on neither drm-next nor
drm-misc-next.
While at it, could you you reorder the other header alphabetically to
make this kind of issue easier to notice ?
>
> struct panel_bridge {
> struct drm_bridge bridge;
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2019-05-14 7:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-14 7:31 [PATCH] drm/bridge: Remove duplicate header Sabyasachi Gupta
2019-05-14 7:35 ` Laurent Pinchart [this message]
2019-05-16 13:15 ` Sabyasachi Gupta
2019-05-16 13:43 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190514073542.GA4969@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=architt@codeaurora.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jrdr.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sabyasachi.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).