From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92489C04AB4 for ; Tue, 14 May 2019 13:01:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5E24621743 for ; Tue, 14 May 2019 13:01:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="KR2ftx3L" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726302AbfENNB0 (ORCPT ); Tue, 14 May 2019 09:01:26 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:35157 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725562AbfENNB0 (ORCPT ); Tue, 14 May 2019 09:01:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=0kFdElstit5HS2EU/3V72XmqkmzHX/hLJaDRJlo92tE=; b=KR2ftx3Legw5rt2nBzRBv3At7m c6sBkIA+LG5oK99YSWNQ72RddWtfX4emfxqhnEN2D+AeATdWtPL7NeWmnWFp4Sx/rAFyeXfUaVuEY hOikx6j5xLKLnzO48LCjDTXBNX0pbnEUqrlcCp9bwbS9gMd6kF4hwSBn2UyjZxQW3CBg=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hQX3R-0002SK-P9; Tue, 14 May 2019 15:01:13 +0200 Date: Tue, 14 May 2019 15:01:13 +0200 From: Andrew Lunn To: Sagar Kadam Cc: Rob Herring , mark.rutland@arm.com, peter@korsgaard.com, Palmer Dabbelt , Paul Walmsley , linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 v2 1/3] dt-bindings: i2c: extend existing opencore bindings. Message-ID: <20190514130113.GB5892@lunn.ch> References: <1557242108-13580-1-git-send-email-sagar.kadam@sifive.com> <1557242108-13580-2-git-send-email-sagar.kadam@sifive.com> <20190513205615.GA5844@bogus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > > + */ > > > + i2c@10030000 { > > > + compatible = "sifive,i2c0","sifive,fu540-c000-i2c"; > > > + reg = <0x0 0x10030000 0x0 0x1000>; > > > + reg-names = "i2c-control"; > > > > Not doucmented. > In v1, I had added a new binding file as sifive-i2c-ocores.txt for > SiFive i2c core. > After Andrew's suggestion, extending the available i2c-ocores.txt > seemed to be a better idea rather than adding a new file. > so added an example node which is HiFive specific in the existing file. > Please let me know if I need to handle this in a different way. Hi Sagar Is reg-names actually needed? Andrew