From: Oleksandr Natalenko <oleksandr@redhat.com>
To: Timofey Titovets <nefelim4ag@gmail.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
Kirill Tkhai <ktkhai@virtuozzo.com>,
Vlastimil Babka <vbabka@suse.cz>, Michal Hocko <mhocko@suse.com>,
Matthew Wilcox <willy@infradead.org>,
Pavel Tatashin <pasha.tatashin@soleen.com>,
Aaron Tomlin <atomlin@redhat.com>,
Grzegorz Halat <ghalat@redhat.com>,
linux-mm@kvack.org, linux-api@vger.kernel.org,
Hugh Dickins <hughd@google.com>
Subject: Re: [PATCH RFC v2 4/4] mm/ksm: add force merging/unmerging documentation
Date: Wed, 15 May 2019 08:26:39 +0200 [thread overview]
Message-ID: <20190515062639.qpqdkbrmujhnxfg7@butterfly.localdomain> (raw)
In-Reply-To: <CAGqmi77gESF0h8ZduHm8TTPKRqQLGFdCP15TAW5skDwZnL85YA@mail.gmail.com>
Hi.
On Wed, May 15, 2019 at 03:53:55AM +0300, Timofey Titovets wrote:
> LGTM for whole series
>
> Reviewed-by: Timofey Titovets <nefelim4ag@gmail.com>
>
> вт, 14 мая 2019 г. в 16:17, Oleksandr Natalenko <oleksandr@redhat.com>:
> >
> > Document respective sysfs knob.
> >
> > Signed-off-by: Oleksandr Natalenko <oleksandr@redhat.com>
> > ---
> > Documentation/admin-guide/mm/ksm.rst | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
> >
> > diff --git a/Documentation/admin-guide/mm/ksm.rst b/Documentation/admin-guide/mm/ksm.rst
> > index 9303786632d1..4302b92910ec 100644
> > --- a/Documentation/admin-guide/mm/ksm.rst
> > +++ b/Documentation/admin-guide/mm/ksm.rst
> > @@ -78,6 +78,17 @@ KSM daemon sysfs interface
> > The KSM daemon is controlled by sysfs files in ``/sys/kernel/mm/ksm/``,
> > readable by all but writable only by root:
> >
> > +force_madvise
> > + write-only control to force merging/unmerging for specific
> > + task.
> > +
> > + To mark the VMAs as mergeable, use:
> > + ``echo PID > /sys/kernel/mm/ksm/force_madvise``
> > +
> > + To unmerge all the VMAs, use:
> > + ``echo -PID > /sys/kernel/mm/ksm/force_madvise``
> > + (note the prepending "minus")
> > +
> In patch 3/4 you have special case with PID 0,
> may be that also must be documented here?
Thanks for the review. Yes, this is a valid point, I'll document it too.
>
> > pages_to_scan
> > how many pages to scan before ksmd goes to sleep
> > e.g. ``echo 100 > /sys/kernel/mm/ksm/pages_to_scan``.
> > --
> > 2.21.0
> >
>
>
> --
> Have a nice day,
> Timofey.
--
Best regards,
Oleksandr Natalenko (post-factum)
Senior Software Maintenance Engineer
next prev parent reply other threads:[~2019-05-15 6:26 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-14 13:16 [PATCH RFC v2 0/4] mm/ksm: add option to automerge VMAs Oleksandr Natalenko
2019-05-14 13:16 ` [PATCH RFC v2 1/4] mm/ksm: introduce ksm_enter() helper Oleksandr Natalenko
2019-05-14 13:16 ` [PATCH RFC v2 2/4] mm/ksm: introduce ksm_leave() helper Oleksandr Natalenko
2019-05-14 13:16 ` [PATCH RFC v2 3/4] mm/ksm: introduce force_madvise knob Oleksandr Natalenko
2019-05-14 13:22 ` Aaron Tomlin
2019-05-15 0:48 ` Timofey Titovets
2019-05-14 13:16 ` [PATCH RFC v2 4/4] mm/ksm: add force merging/unmerging documentation Oleksandr Natalenko
2019-05-15 0:53 ` Timofey Titovets
2019-05-15 6:26 ` Oleksandr Natalenko [this message]
2019-05-14 14:41 ` [PATCH RFC v2 0/4] mm/ksm: add option to automerge VMAs Michal Hocko
2019-05-14 14:51 ` Michal Hocko
2019-05-15 6:25 ` Oleksandr Natalenko
2019-05-15 6:53 ` Michal Hocko
2019-05-15 7:37 ` Oleksandr Natalenko
2019-05-15 8:33 ` Michal Hocko
2019-05-15 8:51 ` Oleksandr Natalenko
2019-05-15 14:24 ` Michal Hocko
2019-05-15 14:51 ` Michal Hocko
2019-05-15 15:15 ` Greg KH
2019-05-16 7:47 ` Michal Hocko
2019-05-16 7:53 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190515062639.qpqdkbrmujhnxfg7@butterfly.localdomain \
--to=oleksandr@redhat.com \
--cc=atomlin@redhat.com \
--cc=ghalat@redhat.com \
--cc=hughd@google.com \
--cc=ktkhai@virtuozzo.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=nefelim4ag@gmail.com \
--cc=pasha.tatashin@soleen.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).