From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23FBAC46460 for ; Wed, 15 May 2019 11:46:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EA34D2053B for ; Wed, 15 May 2019 11:46:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557920801; bh=3dqHaKVa6Z5MG2ih8ovPRqksXJrBN+i9N0bdLmVtv70=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=vYiYq/YCTnJA76cVZ2fJ6r+kX98UMHgl/4bcyD/UvZnhyhgpJPnOKMz+2NZPo+PiZ Tf2+3jDAQzTip3dCtfixJqMa++EsdLR2CGJG5fLkFdTOwQfjNytAIkROKEfdd2bhSH PcjxMDFdLheFrG6ttEEETC/Vw5uo5S8NnMOeCS7A= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731972AbfEOLZT (ORCPT ); Wed, 15 May 2019 07:25:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:35976 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731937AbfEOLZP (ORCPT ); Wed, 15 May 2019 07:25:15 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 363262089E; Wed, 15 May 2019 11:25:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557919514; bh=3dqHaKVa6Z5MG2ih8ovPRqksXJrBN+i9N0bdLmVtv70=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Q7Hd0BQa3Zig2G4FJEObFdg/KFh3oXMTVWh1OA9Xh+5p0ZcIkmkXPYu9ikFARXXCx gpyGBn2kcSNcbS8e/UlvfG8M41EEH5Mv3yeu7NqrLjLyD7+DHwbM6mbhgIwJvUFN/P cPtVfapl59mnKdMf0DRHoSA7TqabOuOVDJvDmjCQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Parthasarathy Bhuvaragan , Jon Maloy , "David S. Miller" Subject: [PATCH 4.19 105/113] tipc: fix hanging clients using poll with EPOLLOUT flag Date: Wed, 15 May 2019 12:56:36 +0200 Message-Id: <20190515090701.630455848@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190515090652.640988966@linuxfoundation.org> References: <20190515090652.640988966@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Parthasarathy Bhuvaragan [ Upstream commit ff946833b70e0c7f93de9a3f5b329b5ae2287b38 ] commit 517d7c79bdb398 ("tipc: fix hanging poll() for stream sockets") introduced a regression for clients using non-blocking sockets. After the commit, we send EPOLLOUT event to the client even in TIPC_CONNECTING state. This causes the subsequent send() to fail with ENOTCONN, as the socket is still not in TIPC_ESTABLISHED state. In this commit, we: - improve the fix for hanging poll() by replacing sk_data_ready() with sk_state_change() to wake up all clients. - revert the faulty updates introduced by commit 517d7c79bdb398 ("tipc: fix hanging poll() for stream sockets"). Fixes: 517d7c79bdb398 ("tipc: fix hanging poll() for stream sockets") Signed-off-by: Parthasarathy Bhuvaragan Acked-by: Jon Maloy Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/tipc/socket.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/net/tipc/socket.c +++ b/net/tipc/socket.c @@ -726,11 +726,11 @@ static __poll_t tipc_poll(struct file *f switch (sk->sk_state) { case TIPC_ESTABLISHED: - case TIPC_CONNECTING: if (!tsk->cong_link_cnt && !tsk_conn_cong(tsk)) revents |= EPOLLOUT; /* fall thru' */ case TIPC_LISTEN: + case TIPC_CONNECTING: if (!skb_queue_empty(&sk->sk_receive_queue)) revents |= EPOLLIN | EPOLLRDNORM; break; @@ -2039,7 +2039,7 @@ static bool tipc_sk_filter_connect(struc return true; /* If empty 'ACK-' message, wake up sleeping connect() */ - sk->sk_data_ready(sk); + sk->sk_state_change(sk); /* 'ACK-' message is neither accepted nor rejected: */ msg_set_dest_droppable(hdr, 1);