From: Matthew Wilcox <willy@infradead.org>
To: "Michal Koutný" <mkoutny@suse.com>
Cc: khlebnikov@yandex-team.ru, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
oleg@redhat.com
Subject: Re: mm: use down_read_killable for locking mmap_sem in access_remote_vm
Date: Wed, 15 May 2019 04:49:54 -0700 [thread overview]
Message-ID: <20190515114954.GB31704@bombadil.infradead.org> (raw)
In-Reply-To: <20190515083825.GJ13687@blackbody.suse.cz>
On Wed, May 15, 2019 at 10:38:26AM +0200, Michal Koutný wrote:
> Hi,
> making this holder of mmap_sem killable was for the reasons of /proc/...
> diagnostics was an idea I was pondeering too. However, I think the
> approach of pretending we read 0 bytes is not correct. The API would IMO
> need to be extended to allow pass a result such as EINTR to the end
> caller.
> Why do you think it's safe to return just 0?
_killable_, not _interruptible_.
The return value will never be seen by userspace because it's dead.
next prev parent reply other threads:[~2019-05-15 11:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-15 8:21 [PATCH] mm: use down_read_killable for locking mmap_sem in access_remote_vm Konstantin Khlebnikov
2019-05-15 8:38 ` Michal Koutný
2019-05-15 8:48 ` Konstantin Khlebnikov
2019-05-16 17:00 ` Michal Koutný
2019-05-15 11:49 ` Matthew Wilcox [this message]
2019-05-15 14:28 ` [PATCH] " Oleg Nesterov
2019-05-17 12:51 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190515114954.GB31704@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=khlebnikov@yandex-team.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mkoutny@suse.com \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).