From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A075EC04E53 for ; Wed, 15 May 2019 21:51:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 66F7E2087E for ; Wed, 15 May 2019 21:51:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="e2niVLUg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727474AbfEOVvD (ORCPT ); Wed, 15 May 2019 17:51:03 -0400 Received: from mail-qt1-f196.google.com ([209.85.160.196]:37886 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726773AbfEOVvC (ORCPT ); Wed, 15 May 2019 17:51:02 -0400 Received: by mail-qt1-f196.google.com with SMTP id o7so1586832qtp.4 for ; Wed, 15 May 2019 14:51:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=qdrlJuKu0Q1qhfC0AybjFB1KcDf+c+74JEBQB6P60MM=; b=e2niVLUgolL8QHs5FIcVJs2//Y6uyfQrdlHwxDKbyeTkr6EJgTOtZegahDE3OTCCxy v394Yr01lUgMjBwgIoiz904OhYOOodF8V1dEIUnIzYyTu+1KaYV+jO/unX+6PZ0KO+SO jmRx+32s7sfj+6JJiueUq4ybDi5ILp6xybRvxbrnJZLqa5E9bVAZgtU4N9sUhegHbdm3 DafIozK9jtjDL/A2csvGkffPWOSvyMwgoNl9ztPC+Qtpdd5CchvUjvO0crRr2NRN6Yhs 6SPMUGY+9iZtuLRuXwL3YsR1zA3cxJG1wd58EXe+xdNx4dEcnWChgNjPiB9uxmp7Y5G+ eYSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=qdrlJuKu0Q1qhfC0AybjFB1KcDf+c+74JEBQB6P60MM=; b=LBqcne+jM2O+Qjjbq4F+AjdIM6eC7gyTFop6ZcmhgkK6wlnBhnUr1/DAMakmw9QEgb DzI3pAlCMIDGTXPZDCzLPXnNI8GSG9UUCCryqE89fkqJc0X3+oVDVw2I9Dp1pPCBZ1dF MTEtPzZqjHLoHyfAId0YamVaQZ6TRWpx9ZkozEN0Dz9ZwfRO5RVRjuJiSD9x9drbSZ6y 5IWkYQYvdTQkO4eFIuJh3r/HxY6u3vappK05w5kRm+MVeZ+a7+E5pwdP6zpIlcR21hJN P7bbhiUipsSoXGth/8BprsXHAFLv2OZrhlefW4aYrHVLYOSrnX/TfsOM9DzuikQ3G7xl 3ybw== X-Gm-Message-State: APjAAAWwTKXD/H6xJ/A+2xwI2gOBUSFIv/wwoX52qdpGmmLd18xPIUzS QDBB9MOAI3PNs6wQWh7lEV81YA== X-Google-Smtp-Source: APXvYqy5GlU131/uqdPdRXV0T+d4W+Y+VlNd5u/nshND9LPTTZwB9wIixSOZCQVGUna2h2CGkYcQNQ== X-Received: by 2002:a0c:d48a:: with SMTP id u10mr16627959qvh.169.1557957061893; Wed, 15 May 2019 14:51:01 -0700 (PDT) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id a11sm1174992qtp.44.2019.05.15.14.51.00 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 15 May 2019 14:51:01 -0700 (PDT) Date: Wed, 15 May 2019 14:50:37 -0700 From: Jakub Kicinski To: Krzesimir Nowak Cc: bpf@vger.kernel.org, iago@kinvolk.io, alban@kinvolk.io, Shuah Khan , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , Andrey Ignatov , Jiong Wang , linux-kselftest@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH bpf v1 3/3] selftests/bpf: Avoid a clobbering of errno Message-ID: <20190515145037.6918f626@cakuba.netronome.com> In-Reply-To: <20190515134731.12611-4-krzesimir@kinvolk.io> References: <20190515134731.12611-1-krzesimir@kinvolk.io> <20190515134731.12611-4-krzesimir@kinvolk.io> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 15 May 2019 15:47:28 +0200, Krzesimir Nowak wrote: > Save errno right after bpf_prog_test_run returns, so we later check > the error code actually set by bpf_prog_test_run, not by some libcap > function. > > Cc: Jakub Kicinski > Fixes: 5a8d5209ac022 ("selftests: bpf: add trivial JSET tests") This commit (of mine) just moved this code into a helper, the bug is older: Fixes: 832c6f2c29ec ("bpf: test make sure to run unpriv test cases in test_verifier") > Signed-off-by: Krzesimir Nowak > --- > tools/testing/selftests/bpf/test_verifier.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/bpf/test_verifier.c b/tools/testing/selftests/bpf/test_verifier.c > index bf0da03f593b..514e17246396 100644 > --- a/tools/testing/selftests/bpf/test_verifier.c > +++ b/tools/testing/selftests/bpf/test_verifier.c > @@ -818,15 +818,17 @@ static int do_prog_test_run(int fd_prog, bool unpriv, uint32_t expected_val, > __u32 size_tmp = sizeof(tmp); > uint32_t retval; > int err; > + int saved_errno; > > if (unpriv) > set_admin(true); > err = bpf_prog_test_run(fd_prog, 1, data, size_data, > tmp, &size_tmp, &retval, NULL); > + saved_errno = errno; > if (unpriv) > set_admin(false); > if (err) { > - switch (errno) { > + switch (saved_errno) { > case 524/*ENOTSUPP*/: > printf("Did not run the program (not supported) "); > return 0;