From: Sean Paul <sean@poorly.run>
To: Doug Anderson <dianders@chromium.org>
Cc: "Sean Paul" <sean@poorly.run>, "Heiko Stuebner" <heiko@sntech.de>,
"Sandy Huang" <hjc@rock-chips.com>,
"Andrzej Hajda" <a.hajda@samsung.com>,
"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
"Neil Armstrong" <narmstrong@baylibre.com>,
"Matthias Kaehlcke" <mka@chromium.org>,
"Sean Paul" <seanpaul@chromium.org>,
"Zheng Yang" <zhengyang@rock-chips.com>,
"Sam Ravnborg" <sam@ravnborg.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
LKML <linux-kernel@vger.kernel.org>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"David Airlie" <airlied@linux.ie>,
"Jernej Skrabec" <jernej.skrabec@siol.net>,
"Daniel Vetter" <daniel@ffwll.ch>
Subject: Re: [PATCH 1/2] drm: bridge: dw-hdmi: Add hooks for suspend/resume
Date: Wed, 15 May 2019 14:05:03 -0400 [thread overview]
Message-ID: <20190515180503.GU17077@art_vandelay> (raw)
In-Reply-To: <CAD=FV=X=ScK0H-ZNcOeEta2BL+f4TSAmXS=D585omXxbRVZcyQ@mail.gmail.com>
On Wed, May 15, 2019 at 11:01:26AM -0700, Doug Anderson wrote:
> Hi,
>
> On Wed, May 15, 2019 at 10:58 AM Sean Paul <sean@poorly.run> wrote:
>
> > On Thu, May 02, 2019 at 03:38:07PM -0700, Douglas Anderson wrote:
> > > On Rockchip rk3288-based Chromebooks when you do a suspend/resume
> > > cycle:
> > >
> > > 1. You lose the ability to detect an HDMI device being plugged in.
> > >
> > > 2. If you're using the i2c bus built in to dw_hdmi then it stops
> > > working.
> > >
> > > Let's add a hook to the core dw-hdmi driver so that we can call it in
> > > dw_hdmi-rockchip in the next commit.
> > >
> > > NOTE: the exact set of steps I've done here in resume come from
> > > looking at the normal dw_hdmi init sequence in upstream Linux plus the
> > > sequence that we did in downstream Chrome OS 3.14. Testing show that
> > > it seems to work, but if an extra step is needed or something here is
> > > not needed we could improve it.
> > >
> > > Signed-off-by: Douglas Anderson <dianders@chromium.org>
> > > ---
> > >
> > > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 21 +++++++++++++++++++++
> > > include/drm/bridge/dw_hdmi.h | 3 +++
> > > 2 files changed, 24 insertions(+)
> > >
> > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> > > index db761329a1e3..4b38bfd43e59 100644
> > > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> > > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> > > @@ -2780,6 +2780,27 @@ void dw_hdmi_unbind(struct dw_hdmi *hdmi)
> > > }
> > > EXPORT_SYMBOL_GPL(dw_hdmi_unbind);
> > >
> > > +int dw_hdmi_suspend(struct dw_hdmi *hdmi)
> > > +{
> > > + return 0;
> > > +}
> > > +EXPORT_SYMBOL_GPL(dw_hdmi_suspend);
> > > +
> > > +int dw_hdmi_resume(struct dw_hdmi *hdmi)
> > > +{
> > > + initialize_hdmi_ih_mutes(hdmi);
> > > +
> > > + dw_hdmi_setup_i2c(hdmi);
> > > + if (hdmi->i2c)
> > > + dw_hdmi_i2c_init(hdmi);
> > > +
> > > + if (hdmi->phy.ops->setup_hpd)
> > > + hdmi->phy.ops->setup_hpd(hdmi, hdmi->phy.data);
> > > +
> > > + return 0;
> > > +}
> > > +EXPORT_SYMBOL_GPL(dw_hdmi_resume);
> >
> > Both patches look good to me, I'd probably prefer to just smash them together,
> > but meh.
> >
> > If no one more authoritative chimes in, I'll apply them to -misc in a few days.
>
> Sure. I can smash them and re-post or you can smash them for me or we
> can keep them as-is. I originally separated because I wasn't sure if
> they'd eventually go through different trees. Just let me know! :-)
Definitely no need to repost. It's entirely possible Andrzej or Heiko prefer to
have the dw-hdmi stuff broken out anyways. My opinion is of little value here :)
Sean
>
> -Doug
--
Sean Paul, Software Engineer, Google / Chromium OS
next prev parent reply other threads:[~2019-05-15 18:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-02 22:38 [PATCH 1/2] drm: bridge: dw-hdmi: Add hooks for suspend/resume Douglas Anderson
2019-05-02 22:38 ` [PATCH 2/2] drm/rockchip: dw_hdmi: Handle suspend/resume Douglas Anderson
2019-05-15 20:04 ` Heiko Stübner
2019-05-16 10:14 ` Laurent Pinchart
2019-05-15 16:22 ` [PATCH 1/2] drm: bridge: dw-hdmi: Add hooks for suspend/resume Doug Anderson
2019-05-15 17:58 ` Sean Paul
2019-05-15 18:01 ` Doug Anderson
2019-05-15 18:05 ` Sean Paul [this message]
2019-05-15 20:03 ` Heiko Stübner
2019-05-16 10:18 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190515180503.GU17077@art_vandelay \
--to=sean@poorly.run \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=jernej.skrabec@siol.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mka@chromium.org \
--cc=narmstrong@baylibre.com \
--cc=sam@ravnborg.org \
--cc=seanpaul@chromium.org \
--cc=ville.syrjala@linux.intel.com \
--cc=zhengyang@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).