From: Steven Rostedt <email@example.com> To: Linus Torvalds <firstname.lastname@example.org> Cc: LKML <email@example.com>, Ingo Molnar <firstname.lastname@example.org>, Andrew Morton <email@example.com> Subject: Re: [GIT PULL] tracing: Updates for 5.2 Date: Wed, 15 May 2019 20:27:29 -0400 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <CAHk-=wjbVZcZXkq5xOnBk3ibXorEYKdmRG5YFzzV-Rw3Q-VUEA@mail.gmail.com> On Wed, 15 May 2019 16:31:34 -0700 Linus Torvalds <email@example.com> wrote: > On Wed, May 15, 2019 at 4:29 PM Linus Torvalds > <firstname.lastname@example.org> wrote: > > > > One option is to just rewrite it something like > > > > const unsigned int offset = offsetof(struct trace_iterator, seq); > > memset(offset+(void *)&iter, 0, sizeof(iter) - offset); > > Side note: make it a well-named helper function, since > "ftrace_dump_buf()" does this too in kernel/trace/trace_kdb.c, and Good point, as they just cut and pasted some of this code. I like the helper function, as it means I don't need to add the sub part, as the function would be more contained. > gets the exact same warning. > I can do this, but it needs testing and all that before sending to you, and may not make the merge window. Is that fine? -- Steve
next prev parent reply other threads:[~2019-05-16 1:48 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-15 17:36 Steven Rostedt 2019-05-15 23:29 ` Linus Torvalds 2019-05-15 23:31 ` Linus Torvalds 2019-05-16 0:27 ` Steven Rostedt [this message] 2019-05-16 1:21 ` Linus Torvalds 2019-05-16 9:08 ` David Laight 2019-05-15 23:50 ` pr-tracker-bot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [GIT PULL] tracing: Updates for 5.2' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).