linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Raphael Gault <raphael.gault@arm.com>
To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: jpoimboe@redhat.com, peterz@infradead.org,
	catalin.marinas@arm.com, will.deacon@arm.com,
	julien.thierry@arm.com, Raphael Gault <raphael.gault@arm.com>
Subject: [RFC 03/16] objtool: Move registers and control flow to arch-dependent code
Date: Thu, 16 May 2019 11:36:42 +0100	[thread overview]
Message-ID: <20190516103655.5509-4-raphael.gault@arm.com> (raw)
In-Reply-To: <20190516103655.5509-1-raphael.gault@arm.com>

The control flow information and register macro definitions were based on
the x86_64 architecture but should be abstract so that each architecture
can define the correct values for the registers, especially the registers
related to the stack frame (Frame Pointer, Stack Pointer and possibly
Return Address).

Signed-off-by: Raphael Gault <raphael.gault@arm.com>
---
 tools/objtool/arch/x86/include/arch_special.h | 36 +++++++++++++++++++
 tools/objtool/{ => arch/x86/include}/cfi.h    |  0
 tools/objtool/check.h                         |  1 +
 tools/objtool/special.c                       | 19 +---------
 4 files changed, 38 insertions(+), 18 deletions(-)
 create mode 100644 tools/objtool/arch/x86/include/arch_special.h
 rename tools/objtool/{ => arch/x86/include}/cfi.h (100%)

diff --git a/tools/objtool/arch/x86/include/arch_special.h b/tools/objtool/arch/x86/include/arch_special.h
new file mode 100644
index 000000000000..424ce47013e3
--- /dev/null
+++ b/tools/objtool/arch/x86/include/arch_special.h
@@ -0,0 +1,36 @@
+/*
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * as published by the Free Software Foundation; either version 2
+ * of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, see <http://www.gnu.org/licenses/>.
+ */
+#ifndef _X86_ARCH_SPECIAL_H
+#define _X86_ARCH_SPECIAL_H
+
+#define EX_ENTRY_SIZE		12
+#define EX_ORIG_OFFSET		0
+#define EX_NEW_OFFSET		4
+
+#define JUMP_ENTRY_SIZE		16
+#define JUMP_ORIG_OFFSET	0
+#define JUMP_NEW_OFFSET		4
+
+#define ALT_ENTRY_SIZE		13
+#define ALT_ORIG_OFFSET		0
+#define ALT_NEW_OFFSET		4
+#define ALT_FEATURE_OFFSET	8
+#define ALT_ORIG_LEN_OFFSET	10
+#define ALT_NEW_LEN_OFFSET	11
+
+#define X86_FEATURE_POPCNT (4 * 32 + 23)
+#define X86_FEATURE_SMAP   (9 * 32 + 20)
+
+#endif /* _X86_ARCH_SPECIAL_H */
diff --git a/tools/objtool/cfi.h b/tools/objtool/arch/x86/include/cfi.h
similarity index 100%
rename from tools/objtool/cfi.h
rename to tools/objtool/arch/x86/include/cfi.h
diff --git a/tools/objtool/check.h b/tools/objtool/check.h
index 71e54f97dbcd..8d809de23029 100644
--- a/tools/objtool/check.h
+++ b/tools/objtool/check.h
@@ -23,6 +23,7 @@
 #include "cfi.h"
 #include "arch.h"
 #include "orc.h"
+#include "arch_special.h"
 #include <linux/hashtable.h>
 
 struct insn_state {
diff --git a/tools/objtool/special.c b/tools/objtool/special.c
index 4e50563d87c6..fd7c928fa1d6 100644
--- a/tools/objtool/special.c
+++ b/tools/objtool/special.c
@@ -26,24 +26,7 @@
 #include "builtin.h"
 #include "special.h"
 #include "warn.h"
-
-#define EX_ENTRY_SIZE		12
-#define EX_ORIG_OFFSET		0
-#define EX_NEW_OFFSET		4
-
-#define JUMP_ENTRY_SIZE		16
-#define JUMP_ORIG_OFFSET	0
-#define JUMP_NEW_OFFSET		4
-
-#define ALT_ENTRY_SIZE		13
-#define ALT_ORIG_OFFSET		0
-#define ALT_NEW_OFFSET		4
-#define ALT_FEATURE_OFFSET	8
-#define ALT_ORIG_LEN_OFFSET	10
-#define ALT_NEW_LEN_OFFSET	11
-
-#define X86_FEATURE_POPCNT (4*32+23)
-#define X86_FEATURE_SMAP   (9*32+20)
+#include "arch_special.h"
 
 struct special_entry {
 	const char *sec;
-- 
2.17.1


  parent reply	other threads:[~2019-05-16 10:38 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-16 10:36 [RFC V2 00/16] objtool: Add support for Arm64 Raphael Gault
2019-05-16 10:36 ` [RFC 01/16] objtool: Add abstraction for computation of symbols offsets Raphael Gault
2019-05-16 10:36 ` [RFC 02/16] objtool: orc: Refactor ORC API for other architectures to implement Raphael Gault
2019-05-16 10:36 ` Raphael Gault [this message]
2019-05-16 10:36 ` [RFC 04/16] objtool: arm64: Add required implementation for supporting the aarch64 architecture in objtool Raphael Gault
2019-05-16 10:36 ` [RFC 05/16] objtool: arm64: Handle hypercalls as nops Raphael Gault
2019-05-16 10:36 ` [RFC 06/16] arm64: alternative: Mark .altinstr_replacement as containing executable instructions Raphael Gault
2019-05-16 10:36 ` [RFC 07/16] objtool: special: Adapt special section handling Raphael Gault
2019-05-16 10:36 ` [RFC 08/16] objtool: arm64: Adapt the stack frame checks for arm architecture Raphael Gault
2019-05-16 10:36 ` [RFC 09/16] arm64: assembler: Add macro to annotate asm function having non standard stack-frame Raphael Gault
2019-05-16 10:36 ` [RFC 10/16] arm64: sleep: Prevent stack frame warnings from objtool Raphael Gault
2019-05-16 10:36 ` [RFC 11/16] objtool: arm64: Enable stack validation for arm64 Raphael Gault
2019-05-16 10:36 ` [RFC 12/16] arm64: kvm: Annotate non-standard stack frame functions Raphael Gault
2019-05-16 10:36 ` [RFC 13/16] arm64: kernel: Add exception on kuser32 to prevent stack analysis Raphael Gault
2019-05-16 10:36 ` [RFC 14/16] arm64: crypto: Add exceptions for crypto object " Raphael Gault
2019-05-16 10:36 ` [RFC 15/16] objtool: Introduce INSN_UNKNOWN type Raphael Gault
2019-05-16 10:36 ` [RFC 16/16] arm64: kernel: Annotate non-standard stack frame functions Raphael Gault
2019-05-16 14:29 ` [RFC V2 00/16] objtool: Add support for Arm64 Josh Poimboeuf
2019-05-21 12:50   ` Raphael Gault
2019-05-22 23:11     ` Josh Poimboeuf
2019-05-28 22:24     ` Josh Poimboeuf
2019-06-13 15:55       ` Raphael Gault
2019-06-13 16:09         ` Josh Poimboeuf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190516103655.5509-4-raphael.gault@arm.com \
    --to=raphael.gault@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=jpoimboe@redhat.com \
    --cc=julien.thierry@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).