From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9272C04AAF for ; Thu, 16 May 2019 11:40:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A33BC21473 for ; Thu, 16 May 2019 11:40:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558006844; bh=aPpF74asY5kHDrkay7c2MpxiyGQsuQ60iTO7Rb3MIVc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=WzMdIxCWIBdJbCjYoloZn62ssVcGxh8KGwL/xOl2VHHNNTJNrnPDnSgPrjaEsBr20 ZNGyEDmAFLtFVOBWCd1BC8u3JPgChjkOn1T8rRbiz01cvdXi/CcfRrgv7yoMAvA9fW AqZT7pnvMVpaGXf3iW3EhwDpuJNwcVIBMJtVIIA8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727854AbfEPLkn (ORCPT ); Thu, 16 May 2019 07:40:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:49072 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727828AbfEPLkk (ORCPT ); Thu, 16 May 2019 07:40:40 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7629E20833; Thu, 16 May 2019 11:40:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558006840; bh=aPpF74asY5kHDrkay7c2MpxiyGQsuQ60iTO7Rb3MIVc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=e/mK02O8AMqnjNKWtWTHvN1tOpUZ0Fx72y8iwXbjpZnhGeoNmaVle+UNyDSYDkmLx dbGS6r7sgWlqTXJRUAzTcm2GMhTWqf7hbnW8rL6K1+rN21DlA4fU2GT6RpFVzMNQXD oS/fcj4AoOyWHfFlyj0YMOiZfDJTFvuFPYcUt2rU= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Tony Lindgren , Pavel Machek , Sebastian Reichel , Sasha Levin , linux-pm@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 09/25] power: supply: cpcap-battery: Fix division by zero Date: Thu, 16 May 2019 07:40:12 -0400 Message-Id: <20190516114029.8682-9-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190516114029.8682-1-sashal@kernel.org> References: <20190516114029.8682-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tony Lindgren [ Upstream commit dbe7208c6c4aec083571f2ec742870a0d0edbea3 ] If called fast enough so samples do not increment, we can get division by zero in kernel: __div0 cpcap_battery_cc_raw_div cpcap_battery_get_property power_supply_get_property.part.1 power_supply_get_property power_supply_show_property power_supply_uevent Fixes: 874b2adbed12 ("power: supply: cpcap-battery: Add a battery driver") Signed-off-by: Tony Lindgren Acked-by: Pavel Machek Signed-off-by: Sebastian Reichel Signed-off-by: Sasha Levin --- drivers/power/supply/cpcap-battery.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/power/supply/cpcap-battery.c b/drivers/power/supply/cpcap-battery.c index 98ba07869c3b0..3bae02380bb22 100644 --- a/drivers/power/supply/cpcap-battery.c +++ b/drivers/power/supply/cpcap-battery.c @@ -221,6 +221,9 @@ static int cpcap_battery_cc_raw_div(struct cpcap_battery_ddata *ddata, int avg_current; u32 cc_lsb; + if (!divider) + return 0; + sample &= 0xffffff; /* 24-bits, unsigned */ offset &= 0x7ff; /* 10-bits, signed */ -- 2.20.1