From: Peter Xu <peterx@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: "Radim Krčmář" <rkrcmar@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
linux-kselftest@vger.kernel.org, kvm@vger.kernel.org,
"Shuah Khan" <shuah@kernel.org>,
"Andrew Jones" <drjones@redhat.com>,
"Vitaly Kuznetsov" <vkuznets@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: selftests: Compile code with warnings enabled
Date: Fri, 17 May 2019 10:45:10 +0800 [thread overview]
Message-ID: <20190517024510.GN16681@xz-x1> (raw)
In-Reply-To: <20190516130257.29445-1-thuth@redhat.com>
Hi, Thomas,
On Thu, May 16, 2019 at 03:02:57PM +0200, Thomas Huth wrote:
> So far the KVM selftests are compiled without any compiler warnings
> enabled. That's quite bad, since we miss a lot of possible bugs this
> way. Let's enable at least "-Wall" and some other useful warning flags
> now.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> This patch fixes most of the warnings in the x86 code already - but
> for some warnings, I was not quite sure (e.g. about the need for the
> kvm_get_supported_cpuid_entry(1) in some tests), so I did not touch
If you mean the two calls in state_test and evmcs_test I would agree
they should be dropped directly.
Just to mention that the patch may not apply cleanly to kvm/queue now
probably because the dirty-log-test.c touchup recently, so may need a
rebase. Otherwise it looks nice at least to me to have these checks.
Thanks,
--
Peter Xu
next prev parent reply other threads:[~2019-05-17 2:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-16 13:02 [PATCH] KVM: selftests: Compile code with warnings enabled Thomas Huth
2019-05-17 2:45 ` Peter Xu [this message]
2019-05-17 7:15 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190517024510.GN16681@xz-x1 \
--to=peterx@redhat.com \
--cc=drjones@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=shuah@kernel.org \
--cc=thuth@redhat.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).