From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DC98C04AB4 for ; Fri, 17 May 2019 07:42:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E443920848 for ; Fri, 17 May 2019 07:42:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558078976; bh=wq+XCTrbx1zUAET7hQKfed4RNF8HmxUCwP221XT7YzY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=kOR2wYBQOfUUbknl1eMHIZC0tVYPU0iUjVmEYRwCoePS/C6sMRF3l/0YVIvWbmWAA pNgCrzhugHI9FlZLgLUqi0bWjoyrqhpCjDpczbsZ1eJ1YSKF9H4WNoUMGBtHFg4/HM VdHxZuADAU+sDU/d9Mugv+SNZX2gdA5UZOq0WNw8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728639AbfEQHmz (ORCPT ); Fri, 17 May 2019 03:42:55 -0400 Received: from mail-lj1-f195.google.com ([209.85.208.195]:42043 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728540AbfEQHmy (ORCPT ); Fri, 17 May 2019 03:42:54 -0400 Received: by mail-lj1-f195.google.com with SMTP id 188so5378670ljf.9; Fri, 17 May 2019 00:42:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=oHNi3Q7jru9V7QHeQJrbcvrvhDMwQwJaNTkhpVbOPeY=; b=nlZN5KR0N7jvQqLFbSGPTwgMqSKoaX1LPjdM6GeU9/GZuJbZP7lltcJdgPioCZUBg/ IM+F3bzOBkKSue/JToywsm4egduquenAUaHpVJpOt/xIuvEAyayMDk6Dbag9WRppVIRZ leYQM+v4rN89e7x+HTUTWSjKnvp6iP4G+07Wphaw5BI5o4aay0mZqdGjzBJho34c+0fb z1pES0fjwLPl9t5LgYLVVpHpavqzn1iF85ROkTGv9EGt9Kb+3mCK/OQ1FvJ/FhdoFWAn 7fF7t5bHcDv/+Psav4h//ww0Z+dSENcTYk/I7wdvsglM8FIrFxpH0lTIIKEb/JUzfENP nl5A== X-Gm-Message-State: APjAAAV/PChIFX84d5kI1iqEHOozsWnn4I+hAptMkKRdGarAwdTydSPf Ofdat4jGlhqHaKhDKUF5V/Mq+Czg X-Google-Smtp-Source: APXvYqxr66sn/KNjZu/bBP4IB6022Cmga4g3l932SwBwSoNm8SDJXM0CuwDynX5Xkv2GevcPszIh7Q== X-Received: by 2002:a2e:84a:: with SMTP id g10mr16425895ljd.98.1558078972663; Fri, 17 May 2019 00:42:52 -0700 (PDT) Received: from xi.terra (c-74bee655.07-184-6d6c6d4.bbcust.telenor.se. [85.230.190.116]) by smtp.gmail.com with ESMTPSA id k81sm1290928ljb.77.2019.05.17.00.42.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 17 May 2019 00:42:51 -0700 (PDT) Received: from johan by xi.terra with local (Exim 4.91) (envelope-from ) id 1hRXVw-0002Pt-Lr; Fri, 17 May 2019 09:42:48 +0200 Date: Fri, 17 May 2019 09:42:48 +0200 From: Johan Hovold To: parna.naveenkumar@gmail.com Cc: johan@kernel.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] USB: serial: mos7840: Prefer 'unsigned int' to bare use of 'unsigned' Message-ID: <20190517074248.GD28564@localhost> References: <20190516130759.12996-1-parna.naveenkumar@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190516130759.12996-1-parna.naveenkumar@gmail.com> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 16, 2019 at 06:37:59PM +0530, parna.naveenkumar@gmail.com wrote: > From: Naveen Kumar Parna > > This fixes checkpatch.pl warning "WARNING: Prefer 'unsigned int' to > bare use of 'unsigned'". Please don't run checkpatch.pl on code that already in the kernel (possibly with the exception of staging). Use it on your own patches before you submit them if you want, and even then don't blindly follow what checkpatch says. Minor coding style issues are better left alone to avoid adding noise and making code forensic and backports harder. And in this case, there's not even anything wrong with the current code. Johan