From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45B97C04AB4 for ; Fri, 17 May 2019 05:34:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0F59620848 for ; Fri, 17 May 2019 05:34:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=canb.auug.org.au header.i=@canb.auug.org.au header.b="XCLpFXxX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727899AbfEQFeo (ORCPT ); Fri, 17 May 2019 01:34:44 -0400 Received: from ozlabs.org ([203.11.71.1]:51269 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726772AbfEQFeo (ORCPT ); Fri, 17 May 2019 01:34:44 -0400 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 454xnD321Lz9s55; Fri, 17 May 2019 15:34:40 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=canb.auug.org.au; s=201702; t=1558071281; bh=bw+Mmk5RPWITtoR+Iv5JYFrtaaLoLeyObgBQwi6dcLI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=XCLpFXxXnkGQ6zm1XaFLysJ4ke+eg0uUNPbVm4eSpUxSymtzBrVgkFWdlV4uNl67y +pg4cjZ7ZGzybJA46gTTF0Y+L/TXqFhjeQ5oTYMNhFw0Gajxy9C1KVvD0GVma5sG26 CzutJfEWCXNyUVktPAaQ/kbycG8nLQgy9f4xv3FeaXnNuUDym9exXMYygCXA4N3iwB CeLJg3Nm0n7+wshwdDxubzDSL+Q2bbmbIirCG7P5v4odEVCBxY7hwNJ3AWRx4fJo/P wOYoiYkd23ko0We7ysw/9iKBahJ7PAFgIaIfowNtOgvC55nTEIJyOzlQrR2wDJSGQD h1wk5f7UOSGLg== Date: Fri, 17 May 2019 15:34:39 +1000 From: Stephen Rothwell To: Masahiro Yamada Cc: linux-kbuild@vger.kernel.org, Sam Ravnborg , Arnd Bergmann , Greg KH , Jessica Yu , Lucas De Marchi , Michael Schmitz , Linus Torvalds , Rusty Russell , Kees Cook , Michal Marek , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] kbuild: check uniqueness of module names Message-ID: <20190517153439.3b479334@canb.auug.org.au> In-Reply-To: <20190517042753.25857-1-yamada.masahiro@socionext.com> References: <20190517042753.25857-1-yamada.masahiro@socionext.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/IlsPisnNmYNysYS_bs/ddIU"; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Sig_/IlsPisnNmYNysYS_bs/ddIU Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Masahiro, Thanks for this, looks good to me. Just a nit below. On Fri, 17 May 2019 13:27:53 +0900 Masahiro Yamada wrote: > > diff --git a/scripts/modules-check.sh b/scripts/modules-check.sh > new file mode 100755 > index 000000000000..c875f6eab01e > --- /dev/null > +++ b/scripts/modules-check.sh > @@ -0,0 +1,20 @@ > +#!/bin/sh > +# SPDX-License-Identifier: GPL-2.0 > + > +set -e > + > +# Check uniqueness of module names > +check_same_name_modules() > +{ > + same_name_modules=3D$(cat modules.order modules.builtin | \ ^ This trailing '\' is unnecessary after a pipe symbol. > + xargs -r basename -a -- | sort | uniq -d) > + > + for m in $same_name_modules > + do > + echo "warning: same basename if the following are built as modules:" >= &2 > + grep -h -e "/$m" modules.order modules.builtin | \ Same here > + sed 's:^kernel/: :' >&2 > + done > +} > + > +check_same_name_modules Reviewed-by: Stephen ROthwell --=20 Cheers, Stephen Rothwell --Sig_/IlsPisnNmYNysYS_bs/ddIU Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAlzeR+8ACgkQAVBC80lX 0Gzmhwf7B10c15F0Cw1Alt+7cctlQvs4IV/Lpxcg/nFDLrKaGl9UEiAOS1NiUong cJuqTud0LO2PP41jUDbNoAwf6a90eLkJ28vhU4xz3l9x7lIHIwd8ziwkmbMHPCrY q6R63Qi6YKRo1ZbJAcKI671d+Dbkv3/VKArWxXHjha17/lYHOTLr15ASO+oaXyz3 oK8IJ6+hX6wCPNV3RHgQ88GrazAaRlH+XefxCtxsV/lX2avmnk8y0rMwkN3v11nq CsOpLdpBCMgAFZ4Kpt3yr/XGDYBM9Gb3cFvkKbVbdKSKOuu6GZlAEd1JUwpdcSea YiAuCZu/OOoiNOhXrv3uDZzEJ48zFg== =Xu3a -----END PGP SIGNATURE----- --Sig_/IlsPisnNmYNysYS_bs/ddIU--