From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3504C04E84 for ; Fri, 17 May 2019 20:42:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 85C1D2083E for ; Fri, 17 May 2019 20:42:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728853AbfEQUmc (ORCPT ); Fri, 17 May 2019 16:42:32 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:37511 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727785AbfEQUmc (ORCPT ); Fri, 17 May 2019 16:42:32 -0400 Received: from callcc.thunk.org (75-104-86-155.mobility.exede.net [75.104.86.155] (may be forged)) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id x4HKgGRv017037 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 17 May 2019 16:42:23 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id 9D722420025; Fri, 17 May 2019 16:28:10 -0400 (EDT) Date: Fri, 17 May 2019 16:28:10 -0400 From: "Theodore Ts'o" To: Lee Jones Cc: Philippe Mazenauer , Andreas Dilger , "linux-ext4@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] ext4: Variable to signed to check return code Message-ID: <20190517202810.GA21961@mit.edu> Mail-Followup-To: Theodore Ts'o , Lee Jones , Philippe Mazenauer , Andreas Dilger , "linux-ext4@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20190517102506.GU4319@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190517102506.GU4319@dell> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 17, 2019 at 11:25:06AM +0100, Lee Jones wrote: > On Fri, 17 May 2019, Philippe Mazenauer wrote: > > > Variables 'n' and 'err' are both used for less-than-zero error checking, > > however both are declared as unsigned. Ensure ext4_map_blocks() and > > add_system_zone() are able to have their return values propagated > > correctly by redefining them both as signed integers. This is already fixed in the ext4.git tree; it will be pushed to Linus shortly. (Thanks to Colin Ian King from Canonical for sending the patch.) > Acked-by: Lee Jones Lee, techncially this should have been Reviewed-by. Acked-by is used by the maintainer when a patch is going in via some other tree other than the Maintainer's (it means the Maintainer has acked the patch). If you are reviewing a patch, the tag you should be adding is Reviewed-by. Cheers, - Ted