From: Lee Jones <lee.jones@linaro.org>
To: Theodore Ts'o <tytso@mit.edu>,
Philippe Mazenauer <philippe.mazenauer@outlook.de>,
Andreas Dilger <adilger.kernel@dilger.ca>,
"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ext4: Variable to signed to check return code
Date: Sat, 18 May 2019 07:38:34 +0100 [thread overview]
Message-ID: <20190518063834.GX4319@dell> (raw)
In-Reply-To: <20190517202810.GA21961@mit.edu>
On Fri, 17 May 2019, Theodore Ts'o wrote:
> On Fri, May 17, 2019 at 11:25:06AM +0100, Lee Jones wrote:
> > On Fri, 17 May 2019, Philippe Mazenauer wrote:
> >
> > > Variables 'n' and 'err' are both used for less-than-zero error checking,
> > > however both are declared as unsigned. Ensure ext4_map_blocks() and
> > > add_system_zone() are able to have their return values propagated
> > > correctly by redefining them both as signed integers.
>
> This is already fixed in the ext4.git tree; it will be pushed to Linus
> shortly. (Thanks to Colin Ian King from Canonical for sending the
> patch.)
>
> > Acked-by: Lee Jones <lee.jones@linaro.org>
>
> Lee, techncially this should have been Reviewed-by. Acked-by is used
> by the maintainer when a patch is going in via some other tree other
> than the Maintainer's (it means the Maintainer has acked the patch).
> If you are reviewing a patch, the tag you should be adding is
> Reviewed-by.
Actually, that's not technically correct.
"- Acked-by: indicates an agreement by another developer (often a
maintainer of the relevant code) that the patch is appropriate for
inclusion into the kernel."
And I, as a developer (and not a Maintainer in this case) do indicate
that this patch is appropriate for inclusion into the kernel.
Reviewed-by has stronger connotations and implies I have in-depth
knowledge of the subsystem/driver AND agree to the Reviewer's
Statement. I use Acked-by in this case as a weaker agreement after a
shallow review of the patch based on its merits alone.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2019-05-18 6:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-17 9:01 [PATCH] ext4: Variable to signed to check return code Philippe Mazenauer
2019-05-17 10:25 ` Lee Jones
2019-05-17 20:28 ` Theodore Ts'o
2019-05-18 6:38 ` Lee Jones [this message]
2019-05-18 19:54 ` Theodore Ts'o
2019-05-20 8:24 ` Lee Jones
2019-05-20 15:36 ` Theodore Ts'o
2019-05-21 7:25 ` Lee Jones
2019-05-21 17:16 ` Theodore Ts'o
2019-05-22 6:59 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190518063834.GX4319@dell \
--to=lee.jones@linaro.org \
--cc=adilger.kernel@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=philippe.mazenauer@outlook.de \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).