From: Vinod Koul <vkoul@kernel.org>
To: Colin King <colin.king@canonical.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
Huang Shijie <sjhuang@iluvatar.ai>,
dmaengine@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dma: dw-axi-dmac: fix null dereference when pointer first is null
Date: Tue, 21 May 2019 10:27:13 +0530 [thread overview]
Message-ID: <20190521045713.GQ15118@vkoul-mobl> (raw)
In-Reply-To: <20190508223329.26796-1-colin.king@canonical.com>
On 08-05-19, 23:33, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> In the unlikely event that axi_desc_get returns a null desc in the
> very first iteration of the while-loop the error exit path ends
> up calling axi_desc_put on a null pointer 'first' and this causes
> a null pointer dereference. Fix this by adding a null check on
> pointer 'first' before calling axi_desc_put.
Applied, thanks
--
~Vinod
prev parent reply other threads:[~2019-05-21 4:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-08 22:33 [PATCH] dma: dw-axi-dmac: fix null dereference when pointer first is null Colin King
2019-05-21 4:57 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190521045713.GQ15118@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=colin.king@canonical.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sjhuang@iluvatar.ai \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).