From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA2BEC04E87 for ; Tue, 21 May 2019 08:50:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C00882173C for ; Tue, 21 May 2019 08:50:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rEyrvCTG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726943AbfEUIux (ORCPT ); Tue, 21 May 2019 04:50:53 -0400 Received: from mail-lj1-f195.google.com ([209.85.208.195]:45503 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726391AbfEUIuw (ORCPT ); Tue, 21 May 2019 04:50:52 -0400 Received: by mail-lj1-f195.google.com with SMTP id r76so15048236lja.12 for ; Tue, 21 May 2019 01:50:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=EXuZkAoJAIgKITpqT/ed3jeYtW/LzF2mHQoWIrpAi0Q=; b=rEyrvCTG0oCL2S5dWHGMbVpYr6RF1pPm7ehHUq5G3IRISyVIB+nZ9J9X8B3J4YvCIh 8989FJPW2KJHwWh1nlh4W9y1Yd82aBSQ2W7cdnrZ0gq42yw4OxgKrAely0YzuTTuRlke SJd/TstoYadCDRj8WUr5QQALI5i0anAkzbnVgVGgwL9Bn+xyrhtR6Zmx+Oo2IcuArRAr aKyq5289MtzoyvDbUdlCEKgiczDs0BFBYe6u/nk+1ieTmiEpGyNLAsjhYIK9iw7hPfVg BWKRHurtFD9OTwUE1ZOmn8ndbdBNQEwxk/pZoClRpTe9wYSjMYkiKSK8iLsoFp5GuzzZ Totw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=EXuZkAoJAIgKITpqT/ed3jeYtW/LzF2mHQoWIrpAi0Q=; b=GH4G1CTPZhVJhh3v2k2lfqkucHZL08ie2R8E9CHPYQmSbstEQEZg5hd95b4oQ62n26 1Cd3mm1SYHLo7qhtwsMVGKq66383EqjFlD42KpJutSopPjkM5XpIV6xXBt8icZ6v2SKI KIES/m8zC7O38QBJjFHQeJmQd2tzWxE31IEB8JgMUI7j8ug7P6Nfa9nKtaBlbufAaxW1 MNXSoZS/HD0C19DWkfLEdI39uSYbB9u2wb/omXkK0mFlyq05j5efXF/mwYE/rt27YS2Y hIb8/U1h0eKPtc/c1NiiyJAk2+l9MIlDRdRad12FnzEhEMLPrIZsqrNFK+5nBJ1eobhT zzhw== X-Gm-Message-State: APjAAAUPnrzLPyyP4rESMKGNxIl2sUTSJJKnV+z8FD5OCybKKFEQNzjc Z+6Hk4SgPJRsjd0+J2MIQuxtRA== X-Google-Smtp-Source: APXvYqySLGoaqi4d5AmtXg7Be/qVUVt2CEjTCxyfwpqOpZ0ct9cLmmnACgNFzZZp0Tjc3rIX2mS+5A== X-Received: by 2002:a2e:964a:: with SMTP id z10mr5529450ljh.22.1558428650168; Tue, 21 May 2019 01:50:50 -0700 (PDT) Received: from centauri (m83-185-80-163.cust.tele2.se. [83.185.80.163]) by smtp.gmail.com with ESMTPSA id q21sm4640044lfa.84.2019.05.21.01.50.48 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 21 May 2019 01:50:49 -0700 (PDT) Date: Tue, 21 May 2019 10:50:47 +0200 From: Niklas Cassel To: Amit Kucheria Cc: Linux Kernel Mailing List , linux-arm-msm , Bjorn Andersson , Andy Gross , David Brown , Li Yang , Shawn Guo , DTML Subject: Re: [PATCHv1 4/8] arm64: dts: qcom: msm8916: Use more generic idle state names Message-ID: <20190521085047.GA22910@centauri> References: <2a0626da4d8d5a1018c351b24b63e5e0d7a45a10.1557486950.git.amit.kucheria@linaro.org> <20190514161220.GC1824@centauri.ideon.se> <20190515130256.GA27174@centauri> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 21, 2019 at 11:08:09AM +0530, Amit Kucheria wrote: > On Wed, May 15, 2019 at 6:33 PM Niklas Cassel wrote: > > > > On Wed, May 15, 2019 at 03:43:19PM +0530, Amit Kucheria wrote: > > > On Tue, May 14, 2019 at 9:42 PM Niklas Cassel wrote: > > > > > > > > On Fri, May 10, 2019 at 04:59:42PM +0530, Amit Kucheria wrote: > > > > > Instead of using Qualcomm-specific terminology, use generic node names > > > > > for the idle states that are easier to understand. Move the description > > > > > into the "idle-state-name" property. > > > > > > > > > > Signed-off-by: Amit Kucheria > > > > > --- > > > > > arch/arm64/boot/dts/qcom/msm8916.dtsi | 11 ++++++----- > > > > > 1 file changed, 6 insertions(+), 5 deletions(-) > > > > > > > > > > diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi > > > > > index ded1052e5693..400b609bb3fd 100644 > > > > > --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi > > > > > +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi > > > > > @@ -110,7 +110,7 @@ > > > > > reg = <0x0>; > > > > > next-level-cache = <&L2_0>; > > > > > enable-method = "psci"; > > > > > - cpu-idle-states = <&CPU_SPC>; > > > > > + cpu-idle-states = <&CPU_SLEEP_0>; > > > > > clocks = <&apcs>; > > > > > operating-points-v2 = <&cpu_opp_table>; > > > > > #cooling-cells = <2>; > > > > > @@ -122,7 +122,7 @@ > > > > > reg = <0x1>; > > > > > next-level-cache = <&L2_0>; > > > > > enable-method = "psci"; > > > > > - cpu-idle-states = <&CPU_SPC>; > > > > > + cpu-idle-states = <&CPU_SLEEP_0>; > > > > > clocks = <&apcs>; > > > > > operating-points-v2 = <&cpu_opp_table>; > > > > > #cooling-cells = <2>; > > > > > @@ -134,7 +134,7 @@ > > > > > reg = <0x2>; > > > > > next-level-cache = <&L2_0>; > > > > > enable-method = "psci"; > > > > > - cpu-idle-states = <&CPU_SPC>; > > > > > + cpu-idle-states = <&CPU_SLEEP_0>; > > > > > clocks = <&apcs>; > > > > > operating-points-v2 = <&cpu_opp_table>; > > > > > #cooling-cells = <2>; > > > > > @@ -146,7 +146,7 @@ > > > > > reg = <0x3>; > > > > > next-level-cache = <&L2_0>; > > > > > enable-method = "psci"; > > > > > - cpu-idle-states = <&CPU_SPC>; > > > > > + cpu-idle-states = <&CPU_SLEEP_0>; > > > > > clocks = <&apcs>; > > > > > operating-points-v2 = <&cpu_opp_table>; > > > > > #cooling-cells = <2>; > > > > > @@ -160,8 +160,9 @@ > > > > > idle-states { > > > > > entry-method="psci"; > > > > > > > > Please add a space before and after "=". > > > > > > > > > > > > > > - CPU_SPC: spc { > > > > > + CPU_SLEEP_0: cpu-sleep-0 { > > > > > > > > While I like your idea of using power state names from > > > > Server Base System Architecture document (SBSA) where applicable, > > > > does each qcom power state have a matching state in SBSA? > > > > > > > > These are the qcom power states: > > > > https://source.codeaurora.org/quic/la/kernel/msm-4.4/tree/Documentation/devicetree/bindings/arm/msm/lpm-levels.txt?h=msm-4.4#n53 > > > > > > > > Note that qcom defines: > > > > "wfi", "retention", "gdhs", "pc", "fpc" > > > > while SBSA simply defines "idle_standby" (aka wfi), "idle_retention", "sleep". > > > > > > > > Unless you know the equivalent name for each qcom power state > > > > (perhaps several qcom power states are really the same SBSA state?), > > > > I think that you should omit the renaming from this patch series. > > > > > > That is what SLEEP_0, SLEEP_1, SLEEP_2 could be used for. > > > > Ok, sounds good to me. > > > > > > > > IOW, all these qcom definitions are nicely represented in the > > > state-name and we could simply stick to SLEEP_0, SLEEP_1 for the node > > > names. There is wide variability in the the names of the qcom idle > > > states across SoC families downstream, so I'd argue against using > > > those for the node names. > > > > > > Just for cpu states (non-wfi) I see the use of the following names > > > downstream across families. The C seems to come from x86 > > > world[1]: > > > > > > - C4, standalone power collapse (spc) > > > - C4, power collapse (fpc) > > > - C2D, retention > > > - C3, power collapse (pc) > > > - C4, rail power collapse (rail-pc) > > > > > > [1] https://www.hardwaresecrets.com/everything-you-need-to-know-about-the-cpu-c-states-power-saving-modes/ > > > > Indeed, there seems to be mixed names used, I've also seen "fpc-def". > > > > So, you have convinced me. > > > > > > Kind regards, > > Niklas > > Can I take that as a Reviewed-by? Reviewed-by: Niklas Cassel