From: Vinod Koul <vkoul@kernel.org>
To: Sibi Sankar <sibis@codeaurora.org>
Cc: bjorn.andersson@linaro.org, robh+dt@kernel.org,
agross@kernel.org, david.brown@linaro.org, mark.rutland@arm.com,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, rnayak@codeaurora.org,
marc.w.gonzalez@free.fr
Subject: Re: [PATCH v4 1/9] soc: qcom: rpmpd: fixup rpmpd set performance state
Date: Tue, 21 May 2019 17:09:33 +0530 [thread overview]
Message-ID: <20190521113933.GJ15118@vkoul-mobl> (raw)
In-Reply-To: <20190513102015.26551-2-sibis@codeaurora.org>
On 13-05-19, 15:50, Sibi Sankar wrote:
> Remoteproc q6v5-mss calls set_performace_state with INT_MAX on
s/performace/performance
> rpmpd. This is currently ignored since it is greater than the
> max supported state. Fixup rpmpd state to max if the required
> state is greater than all the supported states.
>
> Fixes: 075d3db8d10d ("soc: qcom: rpmpd: Add support for get/set performance state")
>
> Reviewed-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
> Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
> ---
> drivers/soc/qcom/rpmpd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/qcom/rpmpd.c b/drivers/soc/qcom/rpmpd.c
> index 005326050c23..235d01870dd8 100644
> --- a/drivers/soc/qcom/rpmpd.c
> +++ b/drivers/soc/qcom/rpmpd.c
> @@ -226,7 +226,7 @@ static int rpmpd_set_performance(struct generic_pm_domain *domain,
> struct rpmpd *pd = domain_to_rpmpd(domain);
>
> if (state > MAX_RPMPD_STATE)
> - goto out;
> + state = MAX_RPMPD_STATE;
>
> mutex_lock(&rpmpd_lock);
>
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
--
~Vinod
next prev parent reply other threads:[~2019-05-21 11:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-13 10:20 [PATCH v4 0/9] RPMPD for QCS404 and MSM8998 Sibi Sankar
2019-05-13 10:20 ` [PATCH v4 1/9] soc: qcom: rpmpd: fixup rpmpd set performance state Sibi Sankar
2019-05-21 11:39 ` Vinod Koul [this message]
2019-05-13 10:20 ` [PATCH v4 2/9] soc: qcom: rpmpd: Add support to set rpmpd state to max Sibi Sankar
2019-05-13 10:20 ` [PATCH v4 3/9] soc: qcom: rpmpd: Modify corner defining macros Sibi Sankar
2019-05-13 10:20 ` [PATCH v4 4/9] dt-bindings: power: Add rpm power domain bindings for qcs404 Sibi Sankar
2019-05-13 10:20 ` [PATCH v4 5/9] soc: qcom: rpmpd: Add QCS404 power-domains Sibi Sankar
2019-05-13 10:20 ` [PATCH v4 6/9] arm64: dts: qcom: qcs404: Add rpmpd node Sibi Sankar
2019-05-13 10:20 ` [PATCH v4 7/9] dt-bindings: power: Add rpm power domain bindings for msm8998 Sibi Sankar
2019-05-13 10:20 ` [PATCH v4 8/9] soc: qcom: rpmpd: Add MSM8998 power-domains Sibi Sankar
2019-05-13 10:20 ` [PATCH v4 9/9] arm64: dts: qcom: msm8998: Add rpmpd node Sibi Sankar
2019-05-17 17:03 ` [PATCH v4 0/9] RPMPD for QCS404 and MSM8998 Jeffrey Hugo
2019-05-21 11:40 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190521113933.GJ15118@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.w.gonzalez@free.fr \
--cc=mark.rutland@arm.com \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=sibis@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).