From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9590C04AAF for ; Tue, 21 May 2019 12:56:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7ED6C217D4 for ; Tue, 21 May 2019 12:56:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558443415; bh=DNJAuBIygsRZsy8YE6AFsvRkHodu3Ps7PRoyN9cJG9w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=ETrEb87UsZ56SElR68iGUaBSuvVj1X06B5ygdQN7AQEIy87D/Hk4wzXGDDYr6nm6Q rACr0FVUdE3wgITgMx/tNf+g8F2EtM/ZCU/iWm9vQKGrtnrTQpr/kgZGduYE/Dmz8j LlTF5LZ9z7iJreChbjtt1Ak2Vwv17Kg+fekorDJ0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728213AbfEUM4y (ORCPT ); Tue, 21 May 2019 08:56:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:42516 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726692AbfEUM4y (ORCPT ); Tue, 21 May 2019 08:56:54 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 566CB21773; Tue, 21 May 2019 12:56:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558443413; bh=DNJAuBIygsRZsy8YE6AFsvRkHodu3Ps7PRoyN9cJG9w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QBjOnqT6AXnI//DQ6VhlhHPldQqPZFA0zrSHyc7t5AiJ/YhrmEIKJvp7cD98aOqej LPMO8J0h/p8266dD9mdgrW6EDw891UUfAP/Fg03Xogs2009MME+23lrgHcTatPbjOp wYd4pbCw+fZwvzAXOz8V6TQeImhjJNEGzJ2Z+8Pc= Date: Tue, 21 May 2019 14:56:51 +0200 From: Greg Kroah-Hartman To: Esben Haabendal Cc: Lee Jones , linux-serial@vger.kernel.org, Jiri Slaby , Nishanth Menon , Vignesh R , Tony Lindgren , Lokesh Vutla , Florian Fainelli , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] serial: 8250: Add support for 8250/16550 as MFD function Message-ID: <20190521125651.GA6264@kroah.com> References: <87o94ejwrx.fsf@haabendal.dk> <20190507133844.GA6194@dell> <87bm05mpmx.fsf@haabendal.dk> <20190514104741.GO4319@dell> <20190514122618.GA18859@kroah.com> <87imudky2o.fsf@haabendal.dk> <20190521100904.GA13612@kroah.com> <87pnocm59v.fsf@haabendal.dk> <20190521111817.GA24911@kroah.com> <87lfz0m3ge.fsf@haabendal.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87lfz0m3ge.fsf@haabendal.dk> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 21, 2019 at 01:50:25PM +0200, Esben Haabendal wrote: > Greg Kroah-Hartman writes: > > > On Tue, May 21, 2019 at 01:11:08PM +0200, Esben Haabendal wrote: > >> Greg Kroah-Hartman writes: > >> > >> >> I will try ad hold back with this thread until you get back to it. > >> > > >> > Ok, I have no idea what is going on here, sorry. This is a really long > >> > and meandering thread, and I can't even find the original patches in my > >> > queue. > >> > > >> > So can you resend things and we can start over? :) > >> > >> Will do. > >> > >> > But note, using a mfd for a uart seems VERY odd to me... > >> > >> Ok. In my case, I have a pcie card with an fpga which includes 5 uart > >> ports, 3 ethernet interfaces and a number of custom IP blocks. > >> I believe that an mfd driver for that pcie card in that case. > > > > I believe you need to fix that fpga to expose individual pci devices > > such that you can properly bind the individual devices to the expected > > drivers :) > > Well, that is really out-of-scope of what I am doing here. Not really, if you have control over the fpga firmware (and odds are you do), just fix that and instantly your device works with all kernels, no need to change anything. Why not do this? > > Seriously, who makes such a broken fpga device that goes against the PCI > > spec that way? Well, not so much as "goes against it", as "ignores all > > of the proper ideas of the past 20 years for working with PCI devices". > > Might be. But that is the firmware I have to work with here, and I > still hope we can find a good solution for implementing a driver without > having to maintain out-of-tree patches. As this hardware will not work on any operating system as-is, why not fix the firmware to keep from having to support a one-off device that no one else would be crazy enough to create? :) thanks, greg k-h