From: Maxime Ripard <maxime.ripard@bootlin.com>
To: luca@z3ntu.xyz
Cc: Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
"moderated list:ARM/Allwinner sunXi SoC support"
<linux-arm-kernel@lists.infradead.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node
Date: Tue, 21 May 2019 15:09:55 +0200 [thread overview]
Message-ID: <20190521130955.3omqwpx3i7njsb3t@flea> (raw)
In-Reply-To: <9B2B83DF-2C91-4DDA-B707-664A792A8BCF@z3ntu.xyz>
[-- Attachment #1: Type: text/plain, Size: 1787 bytes --]
On Tue, May 21, 2019 at 08:43:45AM +0200, luca@z3ntu.xyz wrote:
> On May 20, 2019 1:07:42 PM GMT+02:00, Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> >On Sat, May 18, 2019 at 07:09:30PM +0200, Luca Weiss wrote:
> >> Add a node describing the KEYADC on the A64.
> >>
> >> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> >> ---
> >> arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 7 +++++++
> >> 1 file changed, 7 insertions(+)
> >>
> >> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> >b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> >> index 7734f70e1057..dc1bf8c1afb5 100644
> >> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> >> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> >> @@ -704,6 +704,13 @@
> >> status = "disabled";
> >> };
> >>
> >> + lradc: lradc@1c21800 {
> >> + compatible = "allwinner,sun4i-a10-lradc-keys";
> >> + reg = <0x01c21800 0x100>;
> >> + interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
> >> + status = "disabled";
> >> + };
> >> +
> >
> >The controller is pretty different on the A64 compared to the A10. The
> >A10 has two channels for example, while the A64 has only one.
> >
> >It looks like the one in the A83t though, so you can use that
> >compatible instead.
>
> Looking at the patch for the A83t, the only difference is that it
> uses a 3/4 instead of a 2/3 voltage divider, nothing is changed with
> the channels.
I guess you can reuse the A83t compatible here then, and a more
specific a64 compatible in case we ever need to fix this.
> But I'm also not sure which one (or a different one)
> is used from looking at the "A64 User Manual".
I'm sorry, what are you referring to with "one" in that sentence?
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2019-05-21 13:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-18 17:09 [PATCH] arm64: dts: allwinner: a64: Add lradc node Luca Weiss
2019-05-20 11:07 ` Maxime Ripard
2019-05-21 6:43 ` luca
2019-05-21 13:09 ` Maxime Ripard [this message]
2019-05-21 13:52 ` luca
2019-05-21 14:25 ` Maxime Ripard
2019-05-24 8:35 ` Luca Weiss
2019-05-24 9:20 ` Maxime Ripard
2019-05-31 10:27 ` Luca Weiss
2019-06-03 7:42 ` Maxime Ripard
2019-06-03 15:20 ` Luca Weiss
2019-06-04 8:28 ` Maxime Ripard
2019-06-04 14:42 Luca Weiss
2019-06-04 14:59 ` Maxime Ripard
2019-06-04 15:07 ` Luca Weiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190521130955.3omqwpx3i7njsb3t@flea \
--to=maxime.ripard@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca@z3ntu.xyz \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).