From: Thierry Reding <thierry.reding@gmail.com>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Jon Hunter <jonathanh@nvidia.com>, JC Kuo <jckuo@nvidia.com>,
linux-tegra@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Rob Herring <robh@kernel.org>
Subject: Re: [PATCH 1/3] dt-bindings: phy: tegra-xusb: List PLL power supplies
Date: Tue, 21 May 2019 17:00:44 +0200 [thread overview]
Message-ID: <20190521150044.GA7098@ulmo> (raw)
In-Reply-To: <20190425153444.6281-1-thierry.reding@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2295 bytes --]
On Thu, Apr 25, 2019 at 05:34:42PM +0200, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> These power supplies provide power for various PLLs that are set up and
> driven by the XUSB pad controller. These power supplies were previously
> improperly added to the PCIe and XUSB controllers, but depending on the
> driver probe order, power to the PLLs will not be supplied soon enough
> and cause initialization to fail.
>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> This was previously reviewed here:
>
> https://patchwork.ozlabs.org/patch/1077153/
>
> .../bindings/phy/nvidia,tegra124-xusb-padctl.txt | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
Hi Kishon,
do you have any comments on this series. It's fairly straightforward but
is required in order to make XUSB work properly on Jetson Nano for which
support was merged in v5.2-rc1.
Thanks,
Thierry
>
> diff --git a/Documentation/devicetree/bindings/phy/nvidia,tegra124-xusb-padctl.txt b/Documentation/devicetree/bindings/phy/nvidia,tegra124-xusb-padctl.txt
> index daedb15f322e..9fb682e47c29 100644
> --- a/Documentation/devicetree/bindings/phy/nvidia,tegra124-xusb-padctl.txt
> +++ b/Documentation/devicetree/bindings/phy/nvidia,tegra124-xusb-padctl.txt
> @@ -42,6 +42,18 @@ Required properties:
> - reset-names: Must include the following entries:
> - "padctl"
>
> +For Tegra124:
> +- avdd-pll-utmip-supply: UTMI PLL power supply. Must supply 1.8 V.
> +- avdd-pll-erefe-supply: PLLE reference PLL power supply. Must supply 1.05 V.
> +- avdd-pex-pll-supply: PCIe/USB3 PLL power supply. Must supply 1.05 V.
> +- hvdd-pex-pll-e-supply: High-voltage PLLE power supply. Must supply 3.3 V.
> +
> +For Tegra210:
> +- avdd-pll-utmip-supply: UTMI PLL power supply. Must supply 1.8 V.
> +- avdd-pll-uerefe-supply: PLLE reference PLL power supply. Must supply 1.05 V.
> +- dvdd-pex-pll-supply: PCIe/USB3 PLL power supply. Must supply 1.05 V.
> +- hvdd-pex-pll-e-supply: High-voltage PLLE power supply. Must supply 1.8 V.
> +
> For Tegra186:
> - avdd-pll-erefeut-supply: UPHY brick and reference clock as well as UTMI PHY
> power supply. Must supply 1.8 V.
> --
> 2.21.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2019-05-21 15:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-25 15:34 [PATCH 1/3] dt-bindings: phy: tegra-xusb: List PLL power supplies Thierry Reding
2019-04-25 15:34 ` [PATCH 2/3] phy: tegra: xusb: Add Tegra124 " Thierry Reding
2019-04-25 15:34 ` [PATCH 3/3] phy: tegra: xusb: Add Tegra210 " Thierry Reding
2019-04-26 8:06 ` [PATCH 1/3] dt-bindings: phy: tegra-xusb: List " Jon Hunter
2019-05-21 15:00 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190521150044.GA7098@ulmo \
--to=thierry.reding@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jckuo@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).