From: Jason Gunthorpe <jgg@ziepe.ca>
To: Jerome Glisse <jglisse@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org,
Leon Romanovsky <leonro@mellanox.com>,
Doug Ledford <dledford@redhat.com>,
Artemy Kovalyov <artemyko@mellanox.com>,
Moni Shoua <monis@mellanox.com>,
Mike Marciniszyn <mike.marciniszyn@intel.com>,
Kaike Wan <kaike.wan@intel.com>,
Dennis Dalessandro <dennis.dalessandro@intel.com>
Subject: Re: [PATCH v4 0/1] Use HMM for ODP v4
Date: Wed, 22 May 2019 15:32:03 -0300 [thread overview]
Message-ID: <20190522183203.GE6054@ziepe.ca> (raw)
In-Reply-To: <20190522174852.GA23038@redhat.com>
On Wed, May 22, 2019 at 01:48:52PM -0400, Jerome Glisse wrote:
> From 0b429b2ffbec348e283693cb97d7ffce760d89da Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?J=C3=A9r=C3=B4me=20Glisse?= <jglisse@redhat.com>
> Date: Sat, 8 Dec 2018 15:47:55 -0500
> Subject: [PATCH] RDMA/odp: convert to use HMM for ODP v5
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> Convert ODP to use HMM so that we can build on common infrastructure
> for different class of devices that want to mirror a process address
> space into a device. There is no functional changes.
>
> Changes since v4:
> - Rebase on top of rdma-next
> Changes since v3:
> - Rebase on top of 5.2-rc1
> Changes since v2:
> - Update to match changes to HMM API
> Changes since v1:
> - improved comments
> - simplified page alignment computation
>
> Signed-off-by: Jérôme Glisse <jglisse@redhat.com>
> Cc: Jason Gunthorpe <jgg@mellanox.com>
> Cc: Leon Romanovsky <leonro@mellanox.com>
> Cc: Doug Ledford <dledford@redhat.com>
> Cc: Artemy Kovalyov <artemyko@mellanox.com>
> Cc: Moni Shoua <monis@mellanox.com>
> Cc: Mike Marciniszyn <mike.marciniszyn@intel.com>
> Cc: Kaike Wan <kaike.wan@intel.com>
> Cc: Dennis Dalessandro <dennis.dalessandro@intel.com>
> drivers/infiniband/core/umem_odp.c | 506 +++++++++--------------------
> drivers/infiniband/hw/mlx5/mem.c | 20 +-
> drivers/infiniband/hw/mlx5/mr.c | 2 +-
> drivers/infiniband/hw/mlx5/odp.c | 104 +++---
> include/rdma/ib_umem_odp.h | 47 +--
> 5 files changed, 233 insertions(+), 446 deletions(-)
The kconfig stuff is missing, and it doesn't compile in various cases
I tried.
The kconfig stuff for hmm is also really obnoxious, you can't just
enabe HMM_MIRROR, you have to track down all the little required
elements to get it to turn on..
Once I did get it to compile, I also get warnings:
mm/hmm.c: In function ‘hmm_vma_walk_pud’:
mm/hmm.c:782:28: warning: unused variable ‘pfn’ [-Wunused-variable]
unsigned long i, npages, pfn;
^~~
mm/hmm.c: In function ‘hmm_range_snapshot’:
mm/hmm.c:1027:19: warning: unused variable ‘h’ [-Wunused-variable]
struct hstate *h = hstate_vma(vma);
Because this kernel doesn't have CONFIG_HUGETLB_PAGE
Please fold this into your patch if it has to be resent.. I think it
fixes the compilation problems.
diff --git a/drivers/infiniband/Kconfig b/drivers/infiniband/Kconfig
index cbfbea49f126cd..e3eefd0917985a 100644
--- a/drivers/infiniband/Kconfig
+++ b/drivers/infiniband/Kconfig
@@ -63,7 +63,7 @@ config INFINIBAND_USER_MEM
config INFINIBAND_ON_DEMAND_PAGING
bool "InfiniBand on-demand paging support"
depends on INFINIBAND_USER_MEM
- select MMU_NOTIFIER
+ depends on HMM_MIRROR
default y
---help---
On demand paging support for the InfiniBand subsystem.
diff --git a/include/rdma/ib_umem_odp.h b/include/rdma/ib_umem_odp.h
index e1476e9ebb7906..f760103c07349a 100644
--- a/include/rdma/ib_umem_odp.h
+++ b/include/rdma/ib_umem_odp.h
@@ -115,6 +115,16 @@ static inline size_t ib_umem_odp_num_pages(struct ib_umem_odp *umem_odp)
#define ODP_DMA_ADDR_MASK (~(ODP_READ_ALLOWED_BIT | ODP_WRITE_ALLOWED_BIT))
+#define ODP_READ_BIT (1<<0ULL)
+#define ODP_WRITE_BIT (1<<1ULL)
+/*
+ * The device bit is not use by ODP but is there to full-fill HMM API which
+ * also support device with device memory (like GPU). So from ODP/RDMA POV
+ * this can be ignored.
+ */
+#define ODP_DEVICE_BIT (1<<2ULL)
+#define ODP_FLAGS_BITS 3
+
#ifdef CONFIG_INFINIBAND_ON_DEMAND_PAGING
struct ib_ucontext_per_mm {
@@ -138,16 +148,6 @@ struct ib_umem_odp *ib_alloc_odp_umem(struct ib_umem_odp *root_umem,
unsigned long addr, size_t size);
void ib_umem_odp_release(struct ib_umem_odp *umem_odp);
-#define ODP_READ_BIT (1<<0ULL)
-#define ODP_WRITE_BIT (1<<1ULL)
-/*
- * The device bit is not use by ODP but is there to full-fill HMM API which
- * also support device with device memory (like GPU). So from ODP/RDMA POV
- * this can be ignored.
- */
-#define ODP_DEVICE_BIT (1<<2ULL)
-#define ODP_FLAGS_BITS 3
-
long ib_umem_odp_map_dma_pages(struct ib_umem_odp *umem_odp,
struct hmm_range *range);
next prev parent reply other threads:[~2019-05-22 18:32 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-11 18:13 [PATCH v4 0/1] Use HMM for ODP v4 jglisse
2019-04-11 18:13 ` [PATCH v4 1/1] RDMA/odp: convert to use " jglisse
2019-05-06 19:56 ` [PATCH v4 0/1] Use " Jason Gunthorpe
2019-05-21 20:53 ` Jerome Glisse
2019-05-22 0:52 ` Jason Gunthorpe
2019-05-22 17:48 ` Jerome Glisse
2019-05-22 18:32 ` Jason Gunthorpe [this message]
2019-05-22 19:22 ` Jason Gunthorpe
2019-05-22 21:49 ` Jerome Glisse
2019-05-22 22:43 ` Jason Gunthorpe
2019-05-22 20:12 ` Jason Gunthorpe
2019-05-22 21:12 ` Ralph Campbell
2019-05-22 22:06 ` Jerome Glisse
2019-05-22 22:04 ` Jerome Glisse
2019-05-22 22:39 ` Jason Gunthorpe
2019-05-22 22:42 ` Jerome Glisse
2019-05-22 22:52 ` Jason Gunthorpe
2019-05-22 23:57 ` Jason Gunthorpe
2019-05-23 15:04 ` Jerome Glisse
2019-05-23 15:41 ` Jason Gunthorpe
2019-05-23 15:52 ` Jerome Glisse
2019-05-23 16:34 ` Jason Gunthorpe
2019-05-23 17:33 ` Jerome Glisse
2019-05-23 17:55 ` Jason Gunthorpe
2019-05-23 18:24 ` Jerome Glisse
2019-05-23 19:10 ` Jason Gunthorpe
2019-05-23 19:39 ` Jerome Glisse
2019-05-23 19:47 ` Jason Gunthorpe
2019-05-24 6:40 ` Christoph Hellwig
2019-05-24 12:44 ` RFC: Run a dedicated hmm.git for 5.3 Jason Gunthorpe
2019-05-24 16:27 ` Daniel Vetter
2019-05-24 16:53 ` Jason Gunthorpe
2019-05-24 16:59 ` Daniel Vetter
2019-05-25 22:52 ` Andrew Morton
2019-05-27 19:12 ` Jason Gunthorpe
2019-06-06 15:25 ` Jason Gunthorpe
2019-06-06 19:53 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190522183203.GE6054@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=artemyko@mellanox.com \
--cc=dennis.dalessandro@intel.com \
--cc=dledford@redhat.com \
--cc=jglisse@redhat.com \
--cc=kaike.wan@intel.com \
--cc=leonro@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mike.marciniszyn@intel.com \
--cc=monis@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).