From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88BEEC282CE for ; Wed, 22 May 2019 19:30:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5250621841 for ; Wed, 22 May 2019 19:30:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558553410; bh=BhKkjBXQ2MIcR/VdVoNqa6IxWm7Eac/Nr7VzRmzQ5HU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=VcuCFhOXXeYJ2ZP7kMxOZQ9FCad12c1aP65Kmbym3bHIUE+HRwLFH33nxZWjWMroc paXLj7S+HRxoFzqV+QmU3j4fXWEFeltVvD3KXkvxWstdwagotwuYkw1u8duYicDCu7 ykle/u2iLcQxcgdZkVcx0hyoJ8xQ4Cnw3p+iNRqQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733165AbfEVTaJ (ORCPT ); Wed, 22 May 2019 15:30:09 -0400 Received: from mail.kernel.org ([198.145.29.99]:53430 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733150AbfEVTaG (ORCPT ); Wed, 22 May 2019 15:30:06 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8A14E2177E; Wed, 22 May 2019 19:30:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558553406; bh=BhKkjBXQ2MIcR/VdVoNqa6IxWm7Eac/Nr7VzRmzQ5HU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Nycx+xSSt39SYx3mQD1J7DHbfwYFlRJeLgRwi8ChWtttZPJVlrnEI+OMHiYl2jLFH 8h5Ab/xEGN6BZVx+8a4usB2azpNG9ZBseKZonqEaQlF2hWaeyG6JnbkBTDNQeJnjJJ 04m2ex/JBUl4vTzuZUYpb/dnE4MF5KT1000paVao= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Wen Yang , Linus Walleij , linux-gpio@vger.kernel.org, Sasha Levin Subject: [PATCH AUTOSEL 4.14 055/167] pinctrl: pistachio: fix leaked of_node references Date: Wed, 22 May 2019 15:26:50 -0400 Message-Id: <20190522192842.25858-55-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190522192842.25858-1-sashal@kernel.org> References: <20190522192842.25858-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wen Yang [ Upstream commit 44a4455ac2c6b0981eace683a2b6eccf47689022 ] The call to of_get_child_by_name returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warnings: ./drivers/pinctrl/pinctrl-pistachio.c:1422:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 1360, but without a corresponding object release within this function. Signed-off-by: Wen Yang Cc: Linus Walleij Cc: linux-gpio@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Linus Walleij Signed-off-by: Sasha Levin --- drivers/pinctrl/pinctrl-pistachio.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pinctrl/pinctrl-pistachio.c b/drivers/pinctrl/pinctrl-pistachio.c index 55375b1b3cc81..b2b7e238bda97 100644 --- a/drivers/pinctrl/pinctrl-pistachio.c +++ b/drivers/pinctrl/pinctrl-pistachio.c @@ -1368,6 +1368,7 @@ static int pistachio_gpio_register(struct pistachio_pinctrl *pctl) if (!of_find_property(child, "gpio-controller", NULL)) { dev_err(pctl->dev, "No gpio-controller property for bank %u\n", i); + of_node_put(child); ret = -ENODEV; goto err; } @@ -1375,6 +1376,7 @@ static int pistachio_gpio_register(struct pistachio_pinctrl *pctl) irq = irq_of_parse_and_map(child, 0); if (irq < 0) { dev_err(pctl->dev, "No IRQ for bank %u: %d\n", i, irq); + of_node_put(child); ret = irq; goto err; } -- 2.20.1